| Summary: | Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | gmcharlt, julian.maurice, kyle.m.hall, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear
Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear |
||
|
Description
Kyle M Hall (khall)
2016-12-12 11:58:47 UTC
Created attachment 58112 [details] [review] Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! Created attachment 58160 [details] [review] Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Edie Discher <edischer@cityoffargo.com> Created attachment 58162 [details] [review] Bug 17761 - Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear Due to the fact that the lost and damaged status are contained within the due_due span, when the item is renewed or returned these statuses disappear. Some librarians find this disconcerting and it seems that it would be better to keep the visible. Test Plan: 1) Find a lost item checked out to a patron 2) Renew that lost item via the checkouts table 3) Notice the lost status disappears from that row 4) Apply this patch 5) Refresh the page ( you may want to clear your browser cache as well ) 6) Renew the item again 7) The lost status should remain visible! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Edie Discher <edischer@cityoffargo.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05! I feel like we can change this from enhancement to a bug as the renewal should not make data disappear. This won't get backported to 16.11.x as it is an enhancement. (In reply to Katrin Fischer from comment #6) > This won't get backported to 16.11.x as it is an enhancement. This is actually a bug and was backported to 16.11.x http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=75c3cda017e4998974fad285e21bf63b08e4fce6 Pushed to 3.22.x for 3.22.14 Julian, you are right - sorry for the mistake! Pushed to 16.05.x, for 16.05.07 release |