Summary: | Fix js error on undefined autocomplete(...).data(...) in js_includes.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Templates | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 14570 | ||
Attachments: |
Bug 17790: Fix js error on undefined autocomplete(...).data(...)
Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17790: Fix js error on undefined autocomplete(...).data(...) |
Description
Marcel de Rooy
2016-12-19 11:54:48 UTC
Created attachment 58273 [details] [review] Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> *** Bug 17789 has been marked as a duplicate of this bug. *** Created attachment 58274 [details] [review] Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 58289 [details] [review] Bug 17790: Fix js error on undefined autocomplete(...).data(...) Bug 17418 moved some code to js_includes.inc. But if #findborrower does not exist, you cannot define _renderItem. Trivial fix. Test plan: [1] Find a page where this include is used and #findborrowers is absent. Like about.pl [2] Without this patch, you will have a js error in the js console. [3] With this patch, you should no longer have it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This #findborrower element is present on almost every page, it makes sense to keep it in js_includes.inc Pushed to master for 17.05, thanks Marcel! |