Bug 17800

Summary: Add admin sidebar menu to marc-subfields-structure.pl
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: MARC Bibliographic data supportAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, katrin.fischer, kyle
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl
[SIGNED-OFF] Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl
Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl

Description Aleisha Amohia 2016-12-21 02:59:06 UTC

    
Comment 1 Aleisha Amohia 2016-12-21 03:02:57 UTC
Created attachment 58332 [details] [review]
Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl

Adding to marc-subfields-structure because auth-subfields-structure has
it, so I assume it was just missed when the admin-menu was added.

To test:
1) Go to admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure -> Actions for any tag -> Subfields
2) Notice no admin-menu on the side
3) Apply patch and refresh page
4) Notice admin-menu now shows

Note: the link in the sidebar menu for MARC bibliographic frameworks
does not show as active (bold) from this page. This is fixed in Bug
17794

Sponsored-by: Catalyst IT
Comment 2 Owen Leonard 2016-12-21 16:44:54 UTC
Created attachment 58364 [details] [review]
[SIGNED-OFF] Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl

Adding to marc-subfields-structure because auth-subfields-structure has
it, so I assume it was just missed when the admin-menu was added.

To test:
1) Go to admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure -> Actions for any tag -> Subfields
2) Notice no admin-menu on the side
3) Apply patch and refresh page
4) Notice admin-menu now shows

Note: the link in the sidebar menu for MARC bibliographic frameworks
does not show as active (bold) from this page. This is fixed in Bug
17794

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2016-12-27 15:52:38 UTC
I personally prefer the existing view (less info on a screen where there is already a lot of info), I'd like to get another opinion.
Comment 4 Kyle M Hall 2016-12-30 18:53:16 UTC
Created attachment 58547 [details] [review]
Bug 17800: Add admin sidebar menu to marc-subfields-structure.pl

Adding to marc-subfields-structure because auth-subfields-structure has
it, so I assume it was just missed when the admin-menu was added.

To test:
1) Go to admin -> MARC bibliographic frameworks -> Actions for any
framework -> MARC structure -> Actions for any tag -> Subfields
2) Notice no admin-menu on the side
3) Apply patch and refresh page
4) Notice admin-menu now shows

Note: the link in the sidebar menu for MARC bibliographic frameworks
does not show as active (bold) from this page. This is fixed in Bug
17794

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Katrin Fischer 2017-01-07 23:27:03 UTC
I like the consistency - we already have the sidebar menu for subfields on authority types.
Comment 6 Kyle M Hall 2017-01-13 11:41:04 UTC
Pushed to master for 17.05, thanks Aleisha!
Comment 7 Katrin Fischer 2017-01-15 17:24:44 UTC
This won't get ported back to 16.11.x as it is an enhancement.