Summary: | Remove some modules from showdiffmarc.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17804: Remove some modules from showdiffmarc.pl
[SIGNED-OFF] Bug 17804: Remove some modules from showdiffmarc.pl Bug 17804: Remove some modules from showdiffmarc.pl |
Description
Marcel de Rooy
2016-12-21 13:13:12 UTC
Created attachment 58339 [details] [review] Bug 17804: Remove some modules from showdiffmarc.pl Remove DBI, LibXML, LibXSLT. Add CGI's -utf8 flag. Few whitespace changes. Test plan: [1] Export an existing record to marcxml. [2] Edit the file, make some small changes. [3] Import it again, use a matching rule. [4] Check the diff on Manage staged. (Here is showdiffmarc.pl) Created attachment 58370 [details] [review] [SIGNED-OFF] Bug 17804: Remove some modules from showdiffmarc.pl Remove DBI, LibXML, LibXSLT. Add CGI's -utf8 flag. Few whitespace changes. Test plan: [1] Export an existing record to marcxml. [2] Edit the file, make some small changes. [3] Import it again, use a matching rule. [4] Check the diff on Manage staged. (Here is showdiffmarc.pl) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 58411 [details] [review] Bug 17804: Remove some modules from showdiffmarc.pl Remove DBI, LibXML, LibXSLT. Add CGI's -utf8 flag. Few whitespace changes. Test plan: [1] Export an existing record to marcxml. [2] Edit the file, make some small changes. [3] Import it again, use a matching rule. [4] Check the diff on Manage staged. (Here is showdiffmarc.pl) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Marcel! This looks more like an enhancement of the code. Please let me know if you disagree. |