Bug 17804

Summary: Remove some modules from showdiffmarc.pl
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, kyle
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 17804: Remove some modules from showdiffmarc.pl
[SIGNED-OFF] Bug 17804: Remove some modules from showdiffmarc.pl
Bug 17804: Remove some modules from showdiffmarc.pl

Description Marcel de Rooy 2016-12-21 13:13:12 UTC

    
Comment 1 Marcel de Rooy 2016-12-21 13:19:55 UTC
Created attachment 58339 [details] [review]
Bug 17804: Remove some modules from showdiffmarc.pl

Remove DBI, LibXML, LibXSLT.
Add CGI's -utf8 flag.
Few whitespace changes.

Test plan:
[1] Export an existing record to marcxml.
[2] Edit the file, make some small changes.
[3] Import it again, use a matching rule.
[4] Check the diff on Manage staged. (Here is showdiffmarc.pl)
Comment 2 Owen Leonard 2016-12-21 20:26:35 UTC
Created attachment 58370 [details] [review]
[SIGNED-OFF] Bug 17804: Remove some modules from showdiffmarc.pl

Remove DBI, LibXML, LibXSLT.
Add CGI's -utf8 flag.
Few whitespace changes.

Test plan:
[1] Export an existing record to marcxml.
[2] Edit the file, make some small changes.
[3] Import it again, use a matching rule.
[4] Check the diff on Manage staged. (Here is showdiffmarc.pl)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2016-12-23 10:13:40 UTC
Created attachment 58411 [details] [review]
Bug 17804: Remove some modules from showdiffmarc.pl

Remove DBI, LibXML, LibXSLT.
Add CGI's -utf8 flag.
Few whitespace changes.

Test plan:
[1] Export an existing record to marcxml.
[2] Edit the file, make some small changes.
[3] Import it again, use a matching rule.
[4] Check the diff on Manage staged. (Here is showdiffmarc.pl)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2016-12-23 11:26:44 UTC
Pushed to master for 17.05, thanks Marcel!
Comment 5 Katrin Fischer 2016-12-27 21:57:19 UTC
This looks more like an enhancement of the code. Please let me know if you disagree.