Summary: | due date in intranet search results should use TT date plugin | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Searching | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, julian.maurice, kyle, m.de.rooy, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15822 | ||
Bug Blocks: | 7444 | ||
Attachments: |
Bug 17821 - due date in intranet search results should use TT date plugin
[SIGNED-OFF] Bug 17821 - due date in intranet search results should use TT date plugin Bug 17821 - due date in intranet search results should use TT date plugin |
Description
Fridolin Somers
2016-12-28 14:33:04 UTC
Created attachment 58472 [details] [review] Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" Created attachment 58567 [details] [review] [SIGNED-OFF] Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Fridolin, how this is useful? I understand the consistency point of view, but I do not think it is really valuable. Did you check the other calls to this subroutine to make sure that will not affect another script? (In reply to Jonathan Druart from comment #3) > Fridolin, how this is useful? > I understand the consistency point of view, but I do not think it is really > valuable. The TT date plugin may one day behave differently from the old code in C4::Search. Also we had some cases where date_due is not correct, the TT plugin handles this. > Did you check the other calls to this subroutine to make sure that will not > affect another script? Yep, its not easy since date_due is used a lot. But only intranet results uses it. Still do not think it's needed. Putting it back to the SO queue to get point of view from other QAers. Some of our instances have sometimes an invalid date in items.onload (like 000-00-00). We don't know why but without this patch the page failes on error : "Can't locate object method \"ymd\" via package \"dateonly\" (perh"...) called at /home/koha/src/Koha/DateUtils.pm line 223 (In reply to Fridolin SOMERS from comment #6) > Some of our instances have sometimes an invalid date in items.onload (like > 000-00-00). We don't know why but without this patch the page failes on > error : > "Can't locate object method \"ymd\" via package \"dateonly\" (perh"...) > called at /home/koha/src/Koha/DateUtils.pm line 223 Ok but you are not fixing anything with this patch, just hide other problems: course_reserves/course-details.tt: [% IF cr.item.onloan %] reserve/request.tt: [% IF ( itemloo.onloan ) %] catalogue/detail.tt: [% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfertwhen || item.reservedate ) %] In all of these tests, onloan will be true when you are expecting it to be false. Created attachment 62167 [details] [review] Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Frido! This patch has been pushed to 16.11.x and will be in 16.11.07. Pushed to 16.05.x, for 16.05.12 release Pushed to 3.22.x for 3.22.21 |