Description
Kyle M Hall (khall)
2016-12-29 14:36:52 UTC
Created attachment 58499 [details] [review] Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2 fields Some libraries need to be able to send additional patron data from the extended patron attributes in made up SIP2 fields for the patron information and patron status responses. Test Plan: 1) Apply this patch 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. Make a least one repeatable. 3) Create a patron, add those attibutes for the patron, make sure there are at least two instances of the repeatable code 4) Edit your SIP2 config file, add the following within the login stanza: <patron_attribute field="XX" code="CODE1" /> <patron_attribute field="XY" code="CODE2" /> <patron_attribute field="XZ" code="CODE3" /> 5) Using the sip cli emulator, run patron_information and patron_status_request messages for the patron 6) Note the values you set for the patron attributes are sent in the corrosponding fields! Created attachment 58500 [details] [review] Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2 fields Some libraries need to be able to send additional patron data from the extended patron attributes in made up SIP2 fields for the patron information and patron status responses. Test Plan: 1) Apply this patch 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. Make a least one repeatable. 3) Create a patron, add those attibutes for the patron, make sure there are at least two instances of the repeatable code 4) Edit your SIP2 config file, add the following within the login stanza: <patron_attribute field="XX" code="CODE1" /> <patron_attribute field="XY" code="CODE2" /> <patron_attribute field="XZ" code="CODE3" /> 5) Using the sip cli emulator, run patron_information and patron_status_request messages for the patron 6) Note the values you set for the patron attributes are sent in the corrosponding fields! (In reply to Kyle M Hall from comment #2) > Created attachment 58500 [details] [review] [review] > Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2 > fields > > Some libraries need to be able to send additional patron data from the > extended patron attributes in made up SIP2 fields for the patron > information and patron status responses. > > Test Plan: > 1) Apply this patch > 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. > Make a least one repeatable. > 3) Create a patron, add those attibutes for the patron, make sure there > are at least two instances of the repeatable code > 4) Edit your SIP2 config file, add the following within the login stanza: > <patron_attribute field="XX" code="CODE1" /> > <patron_attribute field="XY" code="CODE2" /> > <patron_attribute field="XZ" code="CODE3" /> > 5) Using the sip cli emulator, run patron_information and > patron_status_request messages for the patron > 6) Note the values you set for the patron attributes are sent in the > corrosponding fields! At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3). When I subsequently clicked on the cgi-bin/koha/admin/categories.pl, I got the following error: "Software error: Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm line 44. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. " Chris, do you get that error on master alone? It would be worth checking on because I cannot imagine how this patch would cause an error like that!
> At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3).
> When I subsequently clicked on the cgi-bin/koha/admin/categories.pl,
> I got the following error:
>
> "Software error:
>
> Template process failed: undef error - round() overflow. Try smaller
> precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm
> line 44.
>
> For help, please send mail to the webmaster ([no address given]), giving
> this error message and the time and date of the error. "
I just realized I never added the dependencies! This patch depends on bug 17792, that's probably why you got that error. (In reply to Kyle M Hall from comment #4) > Chris, do you get that error on master alone? It would be worth checking on > because I cannot imagine how this patch would cause an error like that! > > > At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3). > > When I subsequently clicked on the cgi-bin/koha/admin/categories.pl, > > I got the following error: > > > > "Software error: > > > > Template process failed: undef error - round() overflow. Try smaller > > precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm > > line 44. > > > > For help, please send mail to the webmaster ([no address given]), giving > > this error message and the time and date of the error. " (In reply to Kyle M Hall from comment #5) > I just realized I never added the dependencies! This patch depends on bug > 17792, that's probably why you got that error. > > (In reply to Kyle M Hall from comment #4) > > Chris, do you get that error on master alone? It would be worth checking on > > because I cannot imagine how this patch would cause an error like that! > > > > > At step 3, I added a patron (and added values to CODE1, CODE2, and CODE3). > > > When I subsequently clicked on the cgi-bin/koha/admin/categories.pl, > > > I got the following error: > > > > > > "Software error: > > > > > > Template process failed: undef error - round() overflow. Try smaller > > > precision or use Math::BigFloat at /home/ckirby/koha/Koha/Number/Price.pm > > > line 44. > > > > > > For help, please send mail to the webmaster ([no address given]), giving > > > this error message and the time and date of the error. " Kyle, I am struggling to get bug 17792 to pass the tests (and to run the database update scripts). If you have a chance, look my comments on the bug. Created attachment 60063 [details] [review] Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2 fields Some libraries need to be able to send additional patron data from the extended patron attributes in made up SIP2 fields for the patron information and patron status responses. Test Plan: 1) Apply this patch 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. Make a least one repeatable. 3) Create a patron, add those attibutes for the patron, make sure there are at least two instances of the repeatable code 4) Edit your SIP2 config file, add the following within the login stanza: <patron_attribute field="XX" code="CODE1" /> <patron_attribute field="XY" code="CODE2" /> <patron_attribute field="XZ" code="CODE3" /> 5) Using the sip cli emulator, run patron_information and patron_status_request messages for the patron 6) Note the values you set for the patron attributes are sent in the corrosponding fields! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Daniel Mauchley <dmauchley@duchesne.utah.gov> sub build_patron_attributes_string Could you please add a small test in t/db_dependent/SIP for this new subroutine? Thanks. Created attachment 68622 [details] [review] Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2 fields Some libraries need to be able to send additional patron data from the extended patron attributes in made up SIP2 fields for the patron information and patron status responses. Test Plan: 1) Apply this patch 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. Make a least one repeatable. 3) Create a patron, add those attibutes for the patron, make sure there are at least two instances of the repeatable code 4) Edit your SIP2 config file, add the following within the login stanza: <patron_attribute field="XX" code="CODE1" /> <patron_attribute field="XY" code="CODE2" /> <patron_attribute field="XZ" code="CODE3" /> 5) Using the sip cli emulator, run patron_information and patron_status_request messages for the patron 6) Note the values you set for the patron attributes are sent in the corrosponding fields! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Daniel Mauchley <dmauchley@duchesne.utah.gov> (In reply to Marcel de Rooy from comment #8) > sub build_patron_attributes_string > > Could you please add a small test in t/db_dependent/SIP for this new > subroutine? Thanks. Good idea. I've added them to the initial patch! Created attachment 68655 [details] [review] Bug 17826 - Allow extended patron attributes to be sent in arbitrary SIP2 fields Some libraries need to be able to send additional patron data from the extended patron attributes in made up SIP2 fields for the patron information and patron status responses. Test Plan: 1) Apply this patch 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. Make a least one repeatable. 3) Create a patron, add those attibutes for the patron, make sure there are at least two instances of the repeatable code 4) Edit your SIP2 config file, add the following within the login stanza: <patron_attribute field="XX" code="CODE1" /> <patron_attribute field="XY" code="CODE2" /> <patron_attribute field="XZ" code="CODE3" /> 5) Using the sip cli emulator, run patron_information and patron_status_request messages for the patron 6) Note the values you set for the patron attributes are sent in the corrosponding fields! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Daniel Mauchley <dmauchley@duchesne.utah.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended: added parentheses on line 488 when assigning hashref to array. QA Comment: [1] FAIL pod coverage: POD is missing for build_patron_attributes_string No blocker; the whole module has no POD. [2] Wonder if we should check if ExtendedPatronAttributes has been set. If I disable it, the attributes are still visible. I guess this is a bug on itself, since it comes from Koha::Patron::Attribute(s).. No blocker FAIL C4/SIP/ILS/Patron.pm FAIL pod coverage POD is missing for build_patron_attributes_string Created attachment 72614 [details] [review] Bug 17826 - Add POD For some reason I cannot get the qa script to believe this sub has POD. Pushed to master for 18.05, thanks to everybody involved! Enhancement, not backported for 17.11 *** Bug 10077 has been marked as a duplicate of this bug. *** |