Summary: | Remove C4::Koha::get_infos_of | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, m.de.rooy, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 17846: Remove C4::Koha::get_infos_of
Bug 17846: Remove C4::Koha::get_infos_of Bug 17846: Remove get_infos_of declaration [SIGNED-OFF] Bug 17846: Remove C4::Koha::get_infos_of Bug 17846: Remove get_infos_of declaration Bug 17846: Remove C4::Koha::get_infos_of Bug 17846: Remove get_infos_of declaration |
Description
Jonathan Druart
2017-01-04 11:37:22 UTC
Created attachment 58587 [details] [review] Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent Created attachment 58588 [details] [review] Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent Created attachment 58595 [details] [review] Bug 17846: Remove get_infos_of declaration The function which was removed was still being exported. This removes it completely. Created attachment 58596 [details] [review] [SIGNED-OFF] Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 58597 [details] [review] Bug 17846: Remove get_infos_of declaration The function which was removed was still being exported. This removes it completely. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Test plan for my patch amendment: apply patch 1 git grep get_infos_of -- still one line apply patch 2 git grep get_infos_of -- no lines Left as needs sign off, because of my amendment. Created attachment 59610 [details] [review] Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 59611 [details] [review] Bug 17846: Remove get_infos_of declaration The function which was removed was still being exported. This removes it completely. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Jonathan, Mark! This won't get ported back to 16.11.x as it is an enhancement. |