Bug 17862

Summary: Misleading error message if Apache config is invalid
Product: Koha Reporter: Dan Michael Heggø <danmichaelo+kohabugs>
Component: Installation and upgrade (command-line installer)Assignee: Galen Charlton <gmcharlt>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Dan Michael Heggø 2017-01-07 20:46:41 UTC
When I ran `koha_create`, I got the error message "Koha requires mpm_itk to be enabled within Apache in order to run." from the `check_apache_config` method even though I had mpm_itk enabled.

The real problem was a typo in one of my Apache config file, but the test on line 148 in `koha_create` doesn't distinguish between an invalid Apache config and a valid Apache config with mpm_itk missing:

    /usr/sbin/apachectl -M 2> /dev/null | grep -q 'mpm_itk'

I suggest to check for a valid Apache config before checking for mpm_itk. For instance like so:

if ! /usr/sbin/apachectl configtest 2> /dev/null ; then
cat 1>&2  <<EOM
apachectl configtest failed. Please check your Apache config.
EOM
die
fi