Bug 17864

Summary: Increase test coverage on admin pages
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: Test SuiteAssignee: Mark Tompsett <mtompset>
Status: In Discussion --- QA Contact: Galen Charlton <gmcharlt>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, josef.moravec
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17793    
Bug Blocks:    
Attachments: Test Cases
Test Cases
Bug 17864: Test Cases
Bug 17864: Follow up to add missing tests
Bug 17864: Test Cases
Bug 17864: Follow up to add missing tests
Bug 17793: Test Cases
Bug 17864: Follow up to add missing tests

Description Mark Tompsett 2017-01-07 23:10:25 UTC
Bug 17793 corrects tabs visible in the search area. These tests will check those.
Comment 1 Mark Tompsett 2017-01-07 23:12:27 UTC
Created attachment 58655 [details] [review]
Test Cases
Comment 2 Mark Tompsett 2017-01-07 23:12:59 UTC
Comment on attachment 58655 [details] [review]
Test Cases

Wrong patch.
Comment 3 Mark Tompsett 2017-01-07 23:13:43 UTC
Created attachment 58656 [details] [review]
Test Cases
Comment 4 Josef Moravec 2017-01-09 07:32:03 UTC
I think that should also test:
searchengine/elasticsearch/mappings.pl
clone-rules.pl (see comment 12 on bug 17793)
preferences.pl
systempreferences.pl
Comment 5 Mark Tompsett 2017-01-09 15:20:57 UTC
Created attachment 58685 [details] [review]
Bug 17864: Test Cases

There was no form of testing for the change. In order to test
the perl-side of the changes, I just went to a variety of
URLs to see if they have the expected three tabs.

TEST PLAN
---------
1) Apply this patch
2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/
   -- Or whatever yours is. With or without the trailing /
3) prove -v t/db_dependent/www/prefs-admin_search.t
   -- before applying the other patch, there should be failures.
4) Apply both patches
5) prove -v t/db_dependent/www/prefs-admin_search.t
   -- there should be no failures now.
6) run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 6 Mark Tompsett 2017-01-09 15:21:06 UTC
Created attachment 58686 [details] [review]
Bug 17864: Follow up to add missing tests

This adds tests for the missing items.
Remember the kohadevbox has annoying caching issues,
so close tab, vagrant halt, vagrant up just to be
certain you are not failing because of caching.
Comment 7 Mark Tompsett 2017-04-15 02:57:18 UTC
Looks like I forgot to change the status back to needs sign off. :)
Comment 8 Mark Tompsett 2017-04-15 03:05:11 UTC
P.S. This fails if plug ins are not enabled, as one of the tested pages is plugins. :)
Comment 9 Lee Jamison 2017-06-19 15:58:52 UTC
Created attachment 64435 [details] [review]
Bug 17864: Test Cases

There was no form of testing for the change. In order to test
the perl-side of the changes, I just went to a variety of
URLs to see if they have the expected three tabs.

TEST PLAN
---------
1) Apply this patch
2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/
   -- Or whatever yours is. With or without the trailing /
3) prove -v t/db_dependent/www/prefs-admin_search.t
   -- before applying the other patch, there should be failures.
4) Apply both patches
5) prove -v t/db_dependent/www/prefs-admin_search.t
   -- there should be no failures now.
6) run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

https://bugs.koha-community.org/show_bug.cgi?id=17864

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Updated commit subject to reflect correct bug number.
Works as directed according to test plan and passes QA tools.
Comment 10 Lee Jamison 2017-06-19 15:59:07 UTC
Created attachment 64436 [details] [review]
Bug 17864: Follow up to add missing tests

This adds tests for the missing items.
Remember the kohadevbox has annoying caching issues,
so close tab, vagrant halt, vagrant up just to be
certain you are not failing because of caching.

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Comment 11 Jonathan Druart 2017-07-13 17:57:30 UTC
I am not sure to understand how useful these regression tests can be.
Comment 12 Kyle M Hall 2017-09-01 14:40:29 UTC
Created attachment 66748 [details] [review]
Bug 17793: Test Cases

There was no form of testing for the change. In order to test
the perl-side of the changes, I just went to a variety of
URLs to see if they have the expected three tabs.

TEST PLAN
---------
1) Apply this patch
2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/
   -- Or whatever yours is. With or without the trailing /
3) prove -v t/db_dependent/www/prefs-admin_search.t
   -- before applying the other patch, there should be failures.
4) Apply both patches
5) prove -v t/db_dependent/www/prefs-admin_search.t
   -- there should be no failures now.
6) run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

https://bugs.koha-community.org/show_bug.cgi?id=17864

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 13 Kyle M Hall 2017-09-01 14:40:36 UTC
Created attachment 66749 [details] [review]
Bug 17864: Follow up to add missing tests

This adds tests for the missing items.
Remember the kohadevbox has annoying caching issues,
so close tab, vagrant halt, vagrant up just to be
certain you are not failing because of caching.

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 14 Jonathan Druart 2017-09-01 20:21:32 UTC
(In reply to Jonathan Druart from comment #11)
> I am not sure to understand how useful these regression tests can be.

Answer still needed.