Bug 17874

Summary: Bug 16239 followup - update bootstrap 3 usage
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: TemplatesAssignee: Josef Moravec <josef.moravec>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart+koha, katrin.fischer, kyle, oleonard
Version: masterKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 16239    
Bug Blocks:    
Attachments: Bug 17874: Bug 16239 followup - polishing things
Bug 17874: Bug 16239 followup - polishing things
Bug 17874: Bug 16239 followup - polishing things

Description Josef Moravec 2017-01-10 11:28:10 UTC

    
Comment 1 Josef Moravec 2017-01-10 12:22:36 UTC
Created attachment 58744 [details] [review]
Bug 17874: Bug 16239 followup - polishing things

This patch is made on top of bug 16239 to polish things.

Makes these changes:
- Buttons on add circulation message modal
- Dropdowns has top and bottom margin 4px instead of 3px
- btn-link class (for example in toolbar on advanced search pages)
- Delete circ message is btn-link
- Add new circ message is btn-link

Test plan:
- Confirm that all changes are as described above and that they make sense
Comment 2 Josef Moravec 2017-01-10 12:24:13 UTC
First followup for bug 16239, I am sure there are many other things to do, but it would be useful to have any feedback on this and on the other possible changes
Comment 3 Claire Gravely 2017-01-11 11:33:39 UTC
Created attachment 58807 [details] [review]
Bug 17874: Bug 16239 followup - polishing things

This patch is made on top of bug 16239 to polish things.

Makes these changes:
- Buttons on add circulation message modal
- Dropdowns has top and bottom margin 4px instead of 3px
- btn-link class (for example in toolbar on advanced search pages)
- Delete circ message is btn-link
- Add new circ message is btn-link

Test plan:
- Confirm that all changes are as described above and that they make sense

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Comment 4 Jonathan Druart 2017-01-12 12:17:00 UTC
Created attachment 58870 [details] [review]
Bug 17874: Bug 16239 followup - polishing things

This patch is made on top of bug 16239 to polish things.

Makes these changes:
- Buttons on add circulation message modal
- Dropdowns has top and bottom margin 4px instead of 3px
- btn-link class (for example in toolbar on advanced search pages)
- Delete circ message is btn-link
- Add new circ message is btn-link

Test plan:
- Confirm that all changes are as described above and that they make sense

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Kyle M Hall 2017-01-13 14:41:52 UTC
Pushed to master for 17.05, thanks Josef!
Comment 6 Katrin Fischer 2017-01-15 19:08:27 UTC
Dependent on 16239 which is not in 16.11.x.