Summary: | Possible to upload images with no image name | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Label/patron card printing | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | julian.maurice, kyle, mtj |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17879: Use image filename if no image name is entered
Bug 17879: Use image filename if no image name is entered Bug 17879: Use image filename if no image name is entered |
Description
Aleisha Amohia
2017-01-10 22:20:31 UTC
Created attachment 58788 [details] [review] Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Created attachment 58795 [details] [review] Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 58798 [details] [review] Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Aleisha! Reclassifying this to be a bug - This patch has been pushed to 16.11.x and will be in 16.11.02. Pushed to 3.22.x for 3.22.15 Pushed to 16.05.x, for 16.05.08 release |