Summary: | C4::Installer::PerlModules::version_info() drops data during error handling | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Installation and upgrade (command-line installer) | Assignee: | David Cook <dcook> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | Keywords: | Academy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17887 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17882 - Add missing module test to Installer_PerlModules.t
Bug 17882 - Fix C4::Installer::PerlModules::version_info() Bug 17882 - Fix C4::Installer::PerlModules::version_info() Bug 17882 - Add missing module test to Installer_PerlModules.t Bug 17882 - Fix C4::Installer::PerlModules::version_info() |
Description
David Cook
2017-01-11 06:15:17 UTC
Created attachment 58851 [details] [review] Bug 17882 - Add missing module test to Installer_PerlModules.t Adds a test that checks the values declared for a missing Perl dependency. Created attachment 58852 [details] [review] Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. Created attachment 58853 [details] [review] Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. Created attachment 58854 [details] [review] Bug 17882 - Add missing module test to Installer_PerlModules.t Adds a test that checks the values declared for a missing Perl dependency. Created attachment 58855 [details] [review] Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. Test Plan: 1) Apply patch "Bug 17882 - Add missing module test to Installer_PerlModules.t". 2) Run "perl t/Installer_PerlModules.t" 3) Note the following at the end of the test output: not ok 18 - Minimum version found for missing module # Failed test 'Minimum version found for missing module' # at t/Installer_PerlModules.t line 48. # got: undef # expected: '0.9.3' # Looks like you planned 17 tests but ran 18. # Looks like you failed 1 test of 18 run. 4) Apply patch "Bug 17882 - Fix C4::Installer::PerlModules::version_info()". 5) Run "perl t/Installer_PerlModules.t" 6) Note the following at the end of the test output: ok 18 - Minimum version found for missing module Arg... just noticed the usage doesn't show up for upgrades and installed modules... |