Summary: | Move JavaScript to the footer on staff client catalog pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | claire_gravely, fridolin.somers, jonathan.druart, kyle, testopia |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Medium patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 17418, 17870 | ||
Bug Blocks: | 17858, 20977, 20979 | ||
Attachments: |
Bug 17893 - Move JavaScript to the footer on staff client catalog pages
Bug 17893 - Move JavaScript to the footer on staff client catalog pages Bug 17893 - Move JavaScript to the footer on staff client catalog pages Bug 17893 - Move JavaScript to the footer on staff client catalog pages |
Description
Owen Leonard
2017-01-12 16:43:51 UTC
Created attachment 64603 [details] [review] Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Created attachment 64677 [details] [review] Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Created attachment 66950 [details] [review] Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Created attachment 66962 [details] [review] Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |