Bug 17919

Summary: circ/returns.pl caught in Object Name crossfire
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: CirculationAssignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall, kyle
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17466    
Bug Blocks:    
Attachments: Bug 17919: Koha::Issue is now called Koha::Checkout
Bug 17919: Koha::Issue is now called Koha::Checkout
Bug 17919: (bug 17466 follow-up) Koha::Issue is now called Koha::Checkout

Description Mark Tompsett 2017-01-17 06:30:39 UTC
Koha::Items was renamed to Koha::Checkouts
Find and fix any lingering code.
Only code? circ/returns.pl
Comment 1 Mark Tompsett 2017-01-17 06:38:31 UTC
Created attachment 59059 [details] [review]
Bug 17919: Koha::Issue is now called Koha::Checkout

Ignoring the pluralization or lack thereof:
$ git grep "Koha::Issue"
-- This has results.
But this was renamed by 17796, and supposedly still
in discussion in 16870.

apply this patch, and do the same git.
There will be no results.

This was found while running a prove t/db_dependent/00-strict.t
Comment 2 Claire Gravely 2017-01-17 07:30:08 UTC
Created attachment 59063 [details] [review]
Bug 17919: Koha::Issue is now called Koha::Checkout

Ignoring the pluralization or lack thereof:
$ git grep "Koha::Issue"
-- This has results.
But this was renamed by 17796, and supposedly still
in discussion in 16870.

apply this patch, and do the same git.
There will be no results.

This was found while running a prove t/db_dependent/00-strict.t

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Comment 3 Jonathan Druart 2017-01-17 08:08:55 UTC
Created attachment 59068 [details] [review]
Bug 17919: (bug 17466 follow-up) Koha::Issue is now called Koha::Checkout

Ignoring the pluralization or lack thereof:
$ git grep "Koha::Issue"
-- This has results.
But this was renamed by 17796, and supposedly still
in discussion in 16870.

apply this patch, and do the same git.
There will be no results.

This was found while running a prove t/db_dependent/00-strict.t

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Kyle M Hall 2017-01-18 11:48:41 UTC
Pushed to master for 17.05, thanks Mark!
Comment 5 Katrin Fischer 2017-01-22 16:51:52 UTC
Depends on bug 17466 which is not in 16.11.x - won't be pushed.