Summary: | Adjust some POD lines, fix a few typos | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Developer documentation | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | dcook, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17935: Adjust some POD lines, fix a few typos
Bug 17935: Follow up for C4::Plugin... Bug 17935: Adjust some POD lines, fix a few typos Bug 17935: Follow up for C4::Plugin... Bug 17935: Adjust some POD lines, fix a few typos Bug 17935: Follow up for C4::Plugin... |
Description
Marcel de Rooy
2017-01-18 15:56:06 UTC
Created attachment 59209 [details] [review] Bug 17935: Adjust some POD lines, fix a few typos This patch does the following: [1] Move some POD lines from Cache to Caches. [2] Correct C4::Plugins to Koha::Plugins in POD line of Koha::Plugins [3] POD Koha/AuthorisedValue.pm: lib_opac moved to opac_description [4] The POD in Koha/Patron.pm uses head2 and head3 inconsistently. Ran s/^=head2/=head3/ on those lines (7 substitutions on 7 lines) [5] Correct a copied POD line from reports/issues_stats.pl in reports/reserve_stats.pl. [6] Correct a test description in t/db_dependent/Koha/Authorities.t. You should never delete the library :) [7] Correct typo shouild in a comment of rebuild_zebra.pl Test plan: [1] Read the patch. Does it make sense? [2] Run perldoc Koha/Cache.pm and Koha/Caches.pm [3] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Comment on attachment 59209 [details] [review] Bug 17935: Adjust some POD lines, fix a few typos Review of attachment 59209 [details] [review]: ----------------------------------------------------------------- Eyeballs well. ::: Koha/AuthorisedValue.pm @@ +135,2 @@ > > +my $description = $av->opac_description(); Yep. ::: Koha/Plugins.pm @@ +54,4 @@ > This will return a list of all available plugins, optionally limited by > method or metadata value. > > + my @plugins = Koha::Plugins::GetPlugins({ Yikes! Good catch. ::: misc/migration_tools/rebuild_zebra.pl @@ +187,4 @@ > }; > > # Protect again simultaneous update of the zebra index by using a lock file. > +# Create our own lock directory if it is missing. This should be created its vs "it is" -- nice fix. @@ +187,5 @@ > }; > > # Protect again simultaneous update of the zebra index by using a lock file. > +# Create our own lock directory if it is missing. This should be created > +# by koha-zebra-ctl.sh or at system installation. If the desired directory Yep, 2 spaces after a period is old school punctuation. ::: reports/reserves_stats.pl @@ +43,4 @@ > > =head1 DESCRIPTION > > + Plugin that shows reserve stats Doh! Good catch. ::: t/db_dependent/Koha/Authorities.t @@ +49,4 @@ > is( Koha::Authorities->search->count, $nb_of_authorities + 2, 'The 2 authorities should have been added' ); > > $new_authority_1->delete; > +is( Koha::Authorities->search->count, $nb_of_authorities + 1, 'Delete should have deleted the authority' ); Nice catch. Created attachment 59385 [details] [review] Bug 17935: Follow up for C4::Plugin... TEST PLAN --------- -- apply first patch git grep "C4::Plugin" -- still two references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- apply this patch git grep "C4::Plugin" -- no references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- should look fixed Please enter the commit message for your changes. Lines starting Created attachment 59485 [details] [review] Bug 17935: Adjust some POD lines, fix a few typos This patch does the following: [1] Move some POD lines from Cache to Caches. [2] Correct C4::Plugins to Koha::Plugins in POD line of Koha::Plugins [3] POD Koha/AuthorisedValue.pm: lib_opac moved to opac_description [4] The POD in Koha/Patron.pm uses head2 and head3 inconsistently. Ran s/^=head2/=head3/ on those lines (7 substitutions on 7 lines) [5] Correct a copied POD line from reports/issues_stats.pl in reports/reserve_stats.pl. [6] Correct a test description in t/db_dependent/Koha/Authorities.t. You should never delete the library :) [7] Correct typo shouild in a comment of rebuild_zebra.pl Test plan: [1] Read the patch. Does it make sense? [2] Run perldoc Koha/Cache.pm and Koha/Caches.pm [3] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Cook <dcook@prosentient.com.au> Created attachment 59486 [details] [review] Bug 17935: Follow up for C4::Plugin... TEST PLAN --------- -- apply first patch git grep "C4::Plugin" -- still two references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- apply this patch git grep "C4::Plugin" -- no references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- should look fixed Please enter the commit message for your changes. Lines starting Signed-off-by: David Cook <dcook@prosentient.com.au> Forgot to label the patches as signed off, but you can see that I've signed off both. (In reply to David Cook from comment #6) > Forgot to label the patches as signed off, but you can see that I've signed > off both. Thanks, David. Note that I do not see any real use in labeling patches with SIGNED_OFF. We have a signoff line and a bug status. Created attachment 59579 [details] [review] Bug 17935: Adjust some POD lines, fix a few typos This patch does the following: [1] Move some POD lines from Cache to Caches. [2] Correct C4::Plugins to Koha::Plugins in POD line of Koha::Plugins [3] POD Koha/AuthorisedValue.pm: lib_opac moved to opac_description [4] The POD in Koha/Patron.pm uses head2 and head3 inconsistently. Ran s/^=head2/=head3/ on those lines (7 substitutions on 7 lines) [5] Correct a copied POD line from reports/issues_stats.pl in reports/reserve_stats.pl. [6] Correct a test description in t/db_dependent/Koha/Authorities.t. You should never delete the library :) [7] Correct typo shouild in a comment of rebuild_zebra.pl Test plan: [1] Read the patch. Does it make sense? [2] Run perldoc Koha/Cache.pm and Koha/Caches.pm [3] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 59580 [details] [review] Bug 17935: Follow up for C4::Plugin... TEST PLAN --------- -- apply first patch git grep "C4::Plugin" -- still two references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- apply this patch git grep "C4::Plugin" -- no references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- should look fixed Please enter the commit message for your changes. Lines starting Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master for 17.05, thanks Marcel, Mark! Conflicts in 16.11.x - please rebase! (In reply to Katrin Fischer from comment #11) > Conflicts in 16.11.x - please rebase! I would not backport it. Alright :) |