Bug 17958

Summary: Add the Koha::Notice::Template[s] packages (letter table)
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, kyle
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 17962, 17970, 17971    
Attachments: Bug 17958: Add Koha::Letter[s] packages
Bug 17958: Add tests for Koha::Letter[s]
Bug 17958: Add Koha::Notice::Template[s] packages (letter table)
Bug 17958: Add tests for Koha::Notice::Template[s]
[SIGNED-OFF] Bug 17958: Add Koha::Notice::Template[s] packages (letter table)
[SIGNED-OFF] Bug 17958: Add tests for Koha::Notice::Template[s]
Bug 17958: Add Koha::Notice::Template[s] packages (letter table)
Bug 17958: Add tests for Koha::Notice::Template[s]

Description Jonathan Druart 2017-01-23 10:56:06 UTC
Just add basic Koha::Letter[s] packages using Koha::Object[s]
Comment 1 Jonathan Druart 2017-01-23 11:37:17 UTC
Created attachment 59401 [details] [review]
Bug 17958: Add Koha::Letter[s] packages

This just add Koha::Letter[s] for later uses.

Test plan:
  prove t/db_dependent/Koha/Letters.t
should return green
Comment 2 Jonathan Druart 2017-01-23 11:37:25 UTC
Created attachment 59402 [details] [review]
Bug 17958: Add tests for Koha::Letter[s]
Comment 3 Jonathan Druart 2017-01-23 12:14:00 UTC
Created attachment 59403 [details] [review]
Bug 17958: Add Koha::Notice::Template[s] packages (letter table)

This just add Koha::Letter[s] for later uses.

Test plan:
  prove t/db_dependent/Koha/Notices.t
  should return green
Comment 4 Jonathan Druart 2017-01-23 12:14:25 UTC
Created attachment 59404 [details] [review]
Bug 17958: Add tests for Koha::Notice::Template[s]
Comment 5 Josef Moravec 2017-01-23 21:48:23 UTC
Created attachment 59466 [details] [review]
[SIGNED-OFF] Bug 17958: Add Koha::Notice::Template[s] packages (letter table)

This just add Koha::Letter[s] for later uses.

Test plan:
  prove t/db_dependent/Koha/Notices.t
  should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Josef Moravec 2017-01-23 21:48:31 UTC
Created attachment 59467 [details] [review]
[SIGNED-OFF] Bug 17958: Add tests for Koha::Notice::Template[s]

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Nick Clemens 2017-02-17 11:19:22 UTC
Created attachment 60399 [details] [review]
Bug 17958: Add Koha::Notice::Template[s] packages (letter table)

This just add Koha::Letter[s] for later uses.

Test plan:
  prove t/db_dependent/Koha/Notices.t
  should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens 2017-02-17 11:19:31 UTC
Created attachment 60400 [details] [review]
Bug 17958: Add tests for Koha::Notice::Template[s]

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Kyle M Hall 2017-02-17 11:45:12 UTC
Pushed to master for 17.05, thanks Jonathan!
Comment 10 Katrin Fischer 2017-02-19 20:20:38 UTC
This won't get ported back to 16.11.x as it is an enhancement.