Summary: | REST api: Cities controller should not use ->unblessed | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | josef.moravec, kyle, m.de.rooy, matthias.meusburger |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17932 | ||
Bug Blocks: | |||
Attachments: |
Bug 17992: REST api: Remove the use of ->unblessed from Cities controller
Bug 17992: REST api: Remove the use of ->unblessed from Cities controller Bug 17992: REST api: Remove the use of ->unblessed from Cities controller |
Description
Tomás Cohen Arazi (tcohen)
2017-01-25 12:35:10 UTC
Created attachment 59548 [details] [review] Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D Created attachment 60750 [details] [review] Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 60753 [details] [review] Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Tomas! |