Summary: | HOLDPLACED notice should have access to the reserves table | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Notices | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, julian.maurice, mtj, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17995 - HOLDPLACED notice should have access to the reserves table
Bug 17995 - HOLDPLACED notice should have access to the reserves table Bug 17995 - HOLDPLACED notice should have access to the reserves table |
Description
Nick Clemens (kidclamp)
2017-01-25 17:04:06 UTC
Created attachment 59559 [details] [review] Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated Created attachment 61115 [details] [review] Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 61217 [details] [review] Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the 17.05 release. Thanks! While the change is logical, I think this is an enhancement. I think this is a bug fix, users can select data from the reserves table, but it will not work if they do. You've persuaded me. This patch has been pushed to 16.11.x and will be in 16.11.07. Changed severity to normal according to previous comments. Pushed to 3.22.x for 3.22.20 Pushed to 16.05.x, for 16.05.12 release |