|
Description
Kyle M Hall (khall)
2017-01-26 17:29:46 UTC
Created attachment 59588 [details] [review] Bug 18001 - LocalHoldsPriority can cause multiple holds queue lines for same hold request If LocalHoldsPriority is enabled, and a record level request has more than one item that could fill that hold, there is a possibility that a holds queue row will be generated for the request for each of the available items! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Created attachment 59990 [details] [review] Bug 18001 - LocalHoldsPriority can cause multiple holds queue lines for same hold request If LocalHoldsPriority is enabled, and a record level request has more than one item that could fill that hold, there is a possibility that a holds queue row will be generated for the request for each of the available items! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Please provide tests. I'm pushing this to critical; this will cause item-level holds to be filled by different items. Created attachment 62268 [details] [review] Bug 18001 - Unit Test Created attachment 62269 [details] [review] Bug 18001 - LocalHoldsPriority can cause multiple holds queue lines for same hold request If LocalHoldsPriority is enabled, and a record level request has more than one item that could fill that hold, there is a possibility that a holds queue row will be generated for the request for each of the available items! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Created attachment 62318 [details] [review] Bug 18001 - Unit Test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 62320 [details] [review] Bug 18001 - LocalHoldsPriority can cause multiple holds queue lines for same hold request If LocalHoldsPriority is enabled, and a record level request has more than one item that could fill that hold, there is a possibility that a holds queue row will be generated for the request for each of the available items! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05! These patches have been pushed to 16.11.x and will be in 16.11.07. |