Bug 18040

Summary: Updating buttons on Tools->Upload Local Cover Image
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: ToolsAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: josef.moravec, katrin.fischer, kyle
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 17873    
Attachments: Bug 18040: Updating buttons in Tools -> Upload local cover image
Bug 18040: Updating buttons in Tools -> Upload local cover image
Bug 18040: Updating buttons in Tools -> Upload local cover image
Bug 18040: Updating buttons in Tools -> Upload local cover image

Description Aleisha Amohia 2017-02-02 22:58:42 UTC
There are two buttons on this page - Upload file, Process images - and they have different styling and look ugly. Should use bootstrap3 styling
Comment 1 Aleisha Amohia 2017-02-02 23:01:09 UTC
Created attachment 59833 [details] [review]
Bug 18040: Updating buttons in Tools -> Upload local cover image

To test:
1) Go to Tools -> Upload local cover image
2) Select an image and click Upload file
3) Notice Process images button looks different to Upload file button
4) Apply patch and refresh page
5) Follow steps 1-3 again and notice the changed styling of the buttons

Sponsored-by: Catalyst IT
Comment 2 Mark Tompsett 2017-02-03 14:06:25 UTC
Created attachment 59884 [details] [review]
Bug 18040: Updating buttons in Tools -> Upload local cover image

To test:
1) Go to Tools -> Upload local cover image
2) Select an image and click Upload file
3) Notice Process images button looks different to Upload file button
4) Apply patch and refresh page
5) Follow steps 1-3 again and notice the changed styling of the buttons

Sponsored-by: Catalyst IT

NOTE: Kind of sad that the input type="file" is harder to style.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Jonathan Druart 2017-02-14 12:49:46 UTC
Created attachment 60200 [details] [review]
Bug 18040: Updating buttons in Tools -> Upload local cover image

To test:
1) Go to Tools -> Upload local cover image
2) Select an image and click Upload file
3) Notice Process images button looks different to Upload file button
4) Apply patch and refresh page
5) Follow steps 1-3 again and notice the changed styling of the buttons

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2017-02-16 10:45:43 UTC
Created attachment 60316 [details] [review]
Bug 18040: Updating buttons in Tools -> Upload local cover image

To test:
1) Go to Tools -> Upload local cover image
2) Select an image and click Upload file
3) Notice Process images button looks different to Upload file button
4) Apply patch and refresh page
5) Follow steps 1-3 again and notice the changed styling of the buttons

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Kyle M Hall 2017-02-17 15:46:51 UTC
Pushed to master for 17.05, thanks Aleisha!
Comment 6 Katrin Fischer 2017-02-19 20:44:21 UTC
This won't get ported back to 16.11.x as it is an enhancement and the bootstrap update is not part of 16.11.x.