| Summary: | Reserves.t can fail because of caching issues | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | kyle, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13113 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18045: Fix Reserves.t tests - caching issues
Bug 18045: Fix Reserves.t tests - caching issues Bug 18045: Fix Reserves.t tests - caching issues |
||
|
Description
Jonathan Druart
2017-02-03 09:14:16 UTC
Created attachment 59858 [details] [review] Bug 18045: Fix Reserves.t tests - caching issues If the cache has to be cleaned when marc structure is updated. Before this patch, if the age restriction was not mapped, Reserves.t failed with: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 523. Test plan: Just confirm that the tests still pass and that the changes make sense. Created attachment 59868 [details] [review] Bug 18045: Fix Reserves.t tests - caching issues If the cache has to be cleaned when marc structure is updated. Before this patch, if the age restriction was not mapped, Reserves.t failed with: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 523. Test plan: Just confirm that the tests still pass and that the changes make sense. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> It seems that only removing the key MarcSubfieldStructure- should be enough, but it does not hurt either to remove those four keys. Created attachment 60255 [details] [review] Bug 18045: Fix Reserves.t tests - caching issues If the cache has to be cleaned when marc structure is updated. Before this patch, if the age restriction was not mapped, Reserves.t failed with: Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 523. Test plan: Just confirm that the tests still pass and that the changes make sense. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> It seems that only removing the key MarcSubfieldStructure- should be enough, but it does not hurt either to remove those four keys. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.05, thanks Jonathan! This patch has been pushed to 16.11.x and will be in 16.11.04. |