Summary: | Problem with redirect on logout with CAS | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Authentication | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | critical | ||
Priority: | P5 - low | CC: | chris, dpavlin, fridolin.somers, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 17481 | ||
Bug Blocks: | |||
Attachments: |
Bug 18046 CAS logout infinite redirect
[SIGNED OFF] Bug 18046 CAS logout infinite redirect Bug 18046 CAS logout infinite redirect |
Description
Katrin Fischer
2017-02-03 10:49:58 UTC
Sorry, had the wrong bug number: bug 17481 was the change that changed things... Upping severity a bit as this is a problem for end users in the OPAC and it looks like Koha is killing the browser. We fixed it temporarily by removing the logout.x=1 from the URL used for redirecting on logout: sub logout_cas { my ($query, $type) = @_; my ( $cas, $uri ) = _get_cas_and_service($query, undef, $type); + $uri =~ s/\?logout\.x=1//; print $query->redirect( $cas->logout_url(url => $uri)); } Ah yes, because opac-main.pl looks for the existence of the logout param it will just log them out again and again and again. So your fix is the right fix. I will attach a patch here soon Created attachment 66254 [details] [review] Bug 18046 CAS logout infinite redirect To test (You need a CAS server and CAS configured in Koha) 1/ Login using CAS in Koha 2/ Logout in Koha 3/ Notice you get redirected again and again 4/ Apply patch 5/ Login with CAS, then logout 6/ Notice logout works, but no longer infinitely redirected Created attachment 66282 [details] [review] [SIGNED OFF] Bug 18046 CAS logout infinite redirect To test (You need a CAS server and CAS configured in Koha) 1/ Login using CAS in Koha 2/ Logout in Koha 3/ Notice you get redirected again and again 4/ Apply patch 5/ Login with CAS, then logout 6/ Notice logout works, but no longer infinitely redirected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Patch has been in production use for several months on several instances. Fixes a critical bug. Created attachment 66456 [details] [review] Bug 18046 CAS logout infinite redirect To test (You need a CAS server and CAS configured in Koha) 1/ Login using CAS in Koha 2/ Logout in Koha 3/ Notice you get redirected again and again 4/ Apply patch 5/ Login with CAS, then logout 6/ Notice logout works, but no longer infinitely redirected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Patch has been in production use for several months on several instances. Fixes a critical bug. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks like a typical workaround, but evidently works. Not tested with CAS. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.04. This patch has been pushed to 16.11.x and will be in 16.11.12. |