Bug 18067

Summary:	Validate 'holds per record' according to 'total holds' setting in circulation rules
Product:	Koha	Reporter:	Christopher Brannon <cbrannon>
Component:	System Administration	Assignee:	Bugs List <koha-bugs>
Status:	NEW ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Christopher Brannon 2017-02-06 19:14:36 UTC

The holds per record value should not be allowed to be zero if holds allowed is set to 1 or greater.  If holds per record has a value of zero, a hold can't be placed on that Patron/Item regardless of what value the holds allowed is set to.

To test:
* Create a rule with holds allowed set to any number greater than zero and holds per record set to zero
* Try to place a hold on an item.  Note that you are not allowed.
* Change the rule to allow 1 hold per record.
* Try to place a hold again on an item.  This time the hold is allowed.

The rules make sense as they are, but it doesn't make sense to give holds allowed a value, and then have holds per record contradict it.

Christopher