Summary: | Holds to pull UI improvements | ||
---|---|---|---|
Product: | Koha | Reporter: | Michal Denar <black23> |
Component: | Circulation | Assignee: | Josef Moravec <josef.moravec> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, josef.moravec, katrin.fischer, kyle.m.hall, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 18079 | ||
Attachments: |
Bug 18073: Holds to pull table enhancement
Bug 18073: Holds to pull table enhancement Screenshot of problem with column visibility [SIGNED OFF] Bug 18073: Holds to pull table enhancement Bug 18073: Followup - don't use CONCAT_WS Bug 18073: Holds to pull table enhancement Bug 18073: Followup - don't use CONCAT_WS |
Description
Michal Denar
2017-02-07 14:54:40 UTC
Created attachment 60004 [details] [review] Bug 18073: Holds to pull table enhancement Test plan: 0) apply the patch 1) enable on shelf hold in administration -> circulation and fines rules 2) create some holds on avalaible items 3) go to administration -> columns settings and confirm there is new holds-to-pull table in circulation section 4) go to circulation -> holds to pull page and confirm that 4a) that the page does work as before 4b) there is ne "Column visibility" button in datatable toolbar 4c) the column configuration does work as expected 4d) there is new column "First patron" with link to patron which is first in holds queue for given record 4e) sorting works ax expected 4f) filters (in teh bottom of table) work as expected Created attachment 60006 [details] [review] Bug 18073: Holds to pull table enhancement Test plan: 0) apply the patch 1) enable on shelf hold in administration -> circulation and fines rules 2) create some holds on avalaible items 3) go to administration -> columns settings and confirm there is new holds-to-pull table in circulation section 4) go to circulation -> holds to pull page and confirm that 4a) that the page does work as before 4b) there is ne "Column visibility" button in datatable toolbar 4c) the column configuration does work as expected 4d) there is new column "First patron" with link to patron which is first in holds queue for given record 4e) sorting works ax expected 4f) filters (in teh bottom of table) work as expected Created attachment 60039 [details] Screenshot of problem with column visibility Hi Josef, ran into a problem with the column visibility (see screenshot). Tested together with the patch for bug 18079. Back to testing - realized I forgot to pull latest changes from master and also missed some database updates. Now it started working! Created attachment 60040 [details] [review] [SIGNED OFF] Bug 18073: Holds to pull table enhancement Test plan: 0) apply the patch 1) enable on shelf hold in administration -> circulation and fines rules 2) create some holds on avalaible items 3) go to administration -> columns settings and confirm there is new holds-to-pull table in circulation section 4) go to circulation -> holds to pull page and confirm that 4a) that the page does work as before 4b) there is ne "Column visibility" button in datatable toolbar 4c) the column configuration does work as expected 4d) there is new column "First patron" with link to patron which is first in holds queue for given record 4e) sorting works ax expected 4f) filters (in teh bottom of table) work as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works nicely! https://bugs.koha-community.org/show_bug.cgi?id=18079 Created attachment 60069 [details] [review] Bug 18073: Followup - don't use CONCAT_WS Created attachment 60076 [details] [review] Bug 18073: Holds to pull table enhancement Test plan: 0) apply the patch 1) enable on shelf hold in administration -> circulation and fines rules 2) create some holds on avalaible items 3) go to administration -> columns settings and confirm there is new holds-to-pull table in circulation section 4) go to circulation -> holds to pull page and confirm that 4a) that the page does work as before 4b) there is ne "Column visibility" button in datatable toolbar 4c) the column configuration does work as expected 4d) there is new column "First patron" with link to patron which is first in holds queue for given record 4e) sorting works ax expected 4f) filters (in teh bottom of table) work as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works nicely! https://bugs.koha-community.org/show_bug.cgi?id=18079 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 60077 [details] [review] Bug 18073: Followup - don't use CONCAT_WS Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Josef! This won't get ported back to 16.11.x as it is an enhancement. ... but looking forward to see it in 17.05! |