Summary: | Error when placing a hold and holds per record is set to 999 | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Hold requests | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14695 | ||
Bug Blocks: | |||
Attachments: |
Bug 18076: Replace holds_to_place_count with an input type=text
[SIGNED OFF] Bug 18076: Replace holds_to_place_count with an input type=text Bug 18076: Replace holds_to_place_count with an input type=text |
Description
Katrin Fischer
2017-02-07 22:17:14 UTC
From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE """ The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. I'd suggest to replace it with an input box (type=number). +1 for the input box. Created attachment 60021 [details] [review] Bug 18076: Replace holds_to_place_count with an input type=text From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE """ The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. This patch replaces the dropdown list with an input text. Test plan: - Set circulation conditions - holds per record = 999 - Search for record with items - Go to the holds tab - Search for a patron - Verify that when you send your search, the 'internal server error' is not shown and you see the input text. You should be able to enter a value > than 999 and < 1 Created attachment 60041 [details] [review] [SIGNED OFF] Bug 18076: Replace holds_to_place_count with an input type=text From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE """ The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. This patch replaces the dropdown list with an input text. Test plan: - Set circulation conditions - holds per record = 999 - Search for record with items - Go to the holds tab - Search for a patron - Verify that when you send your search, the 'internal server error' is not shown and you see the input text. You should be able to enter a value > than 999 and < 1 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 60201 [details] [review] Bug 18076: Replace holds_to_place_count with an input type=text From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE """ The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which would otherwise never terminate. If the loop exceeds 1000 iterations then an undef exception will be thrown, reporting the error: WHILE loop terminated (> 1000 iterations) The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set to a higher value if necessary. """ I do not think we want to increase this value, and I do not think we want to display a dropdown list with 1000 entries. This patch replaces the dropdown list with an input text. Test plan: - Set circulation conditions - holds per record = 999 - Search for record with items - Go to the holds tab - Search for a patron - Verify that when you send your search, the 'internal server error' is not shown and you see the input text. You should be able to enter a value > than 999 and < 1 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.05, thanks Jonathan! This patch has been pushed to 16.11.x and will be in 16.11.04. |