Description
Joy Nelson
2017-02-08 21:01:44 UTC
Created attachment 60094 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear Created attachment 60105 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> wondering if we should then also have the same for authority records? Created attachment 60120 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Hi Claire- I've added the same text to the authority export string. Take a look! Thanks and great suggestions! joy (In reply to Claire Gravely from comment #3) > wondering if we should then also have the same for authority records? Created attachment 60124 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 60177 [details] [review] Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Hi Joy, I have added a check on the mimetype of the uploaded file, just in case. Can you confirm it works as you would like? Created attachment 60431 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Joy, only the first patch has been signed off, could you confirm you tested both patches? :) Created attachment 60564 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 60567 [details] [review] Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Current status: Signed Off Created attachment 60568 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Ah, yes. My error in the git bz attach command. Took two tries, but I think I got it done! Thanks! joy (In reply to Jonathan Druart from comment #10) > Joy, only the first patch has been signed off, could you confirm you tested > both patches? :) Why not check the extensions .csv and .txt in javascript when uploading? The mime type check could stay. I guess that application/octet-stream will allow a lot more files that you don't want here. Note that line 77 contains a warning (debug). Please remove it. Created attachment 60643 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Created attachment 60644 [details] [review] Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Amended patch after signoff: Remove one warn debug line Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Created attachment 60645 [details] [review] Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 60646 [details] [review] Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Amended patch after signoff: Remove one warn debug line Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Passed QA under the "Better than before"-pragma. The extension thing is not a blocker and some people want to use files without extension for reasons they should explain themselves :) Pushed to master for 17.05, thanks Joy, Jonathan! These patches have been pushed to 16.11.x and will be in 16.11.05. Introduced bug 18312. |