Bug 18089

Summary: All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: katrin.fischer, mtj
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 18226    
Attachments: Bug 18089 - Unit test
Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
[SIGNED-OFF] Bug 18089 - Unit test
[SIGNED-OFF] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
[SIGNED-OFF] Bug 18089 - Unit test
[SIGNED-OFF] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
Bug 18089 - Unit test
Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
Bug 18089: Remove warnings from tests using DBIx::Class fixtures

Description Kyle M Hall 2017-02-09 11:47:17 UTC
Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear.
Comment 1 Kyle M Hall 2017-02-09 11:49:27 UTC
Created attachment 60055 [details] [review]
Bug 18089 - Unit test
Comment 2 Kyle M Hall 2017-02-09 11:49:34 UTC
Created attachment 60056 [details] [review]
Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch

Due to the way it has been implemented, singleBranchMode is set to an
empty string rather than 0 if there is only one branch. This causes any
block that tests for singleBranchMOde to be 0 to never appear.

Test Plan:
1) Apply this patch set
2) prove t/XSLT.t
Comment 5 Kyle M Hall 2017-02-09 11:55:51 UTC
Created attachment 60061 [details] [review]
[SIGNED-OFF] Bug 18089 - Unit test

Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2017-02-09 11:55:57 UTC
Created attachment 60062 [details] [review]
[SIGNED-OFF] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch

Due to the way it has been implemented, singleBranchMode is set to an
empty string rather than 0 if there is only one branch. This causes any
block that tests for singleBranchMOde to be 0 to never appear.

Test Plan:
1) Apply this patch set
2) prove t/XSLT.t

Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Jonathan Druart 2017-02-09 12:14:18 UTC
Created attachment 60065 [details] [review]
Bug 18089 - Unit test

Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2017-02-09 12:14:57 UTC
Created attachment 60066 [details] [review]
Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch

Due to the way it has been implemented, singleBranchMode is set to an
empty string rather than 0 if there is only one branch. This causes any
block that tests for singleBranchMOde to be 0 to never appear.

Test Plan:
1) Apply this patch set
2) prove t/XSLT.t

Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Jonathan Druart 2017-02-09 12:15:00 UTC
Created attachment 60067 [details] [review]
Bug 18089: Remove warnings from tests using DBIx::Class fixtures

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 10 Kyle M Hall 2017-02-14 14:08:12 UTC
Pushed to master for 17.05, thanks Jonathan!
Comment 11 Katrin Fischer 2017-02-14 20:45:07 UTC
These patches have been pushed to 16.11.x and will be in 16.11.04.
Comment 12 Mason James 2017-02-23 20:21:37 UTC
Pushed to 16.05.x, for 16.05.10 release