Summary: | Allow SIP2 field AE (personal name) to be customized | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall <kyle> |
Component: | SIP2 | Assignee: | Kyle M Hall <kyle> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, katrin.fischer, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 16755 | ||
Bug Blocks: | |||
Attachments: |
Bug 18104 - allow SIP2 field AE (personal name ) to be customized
Bug 18104 - allow SIP2 field AE (personal name ) to be customized Bug 18104 - allow SIP2 field AE (personal name ) to be customized Bug 18104: Add a test for customized name in AE Bug 18104: [QA Follow-up] Add a test for customized name in AE |
Description
Kyle M Hall
2017-02-13 14:11:16 UTC
Created attachment 60845 [details] [review] Bug 18104 - allow SIP2 field AE (personal name ) to be customized Created attachment 60876 [details] [review] Bug 18104 - allow SIP2 field AE (personal name ) to be customized Koha's SIP2 server sends the patron's name in the format "Firstname Surname" which is not very good for machine reading. We need to allow the format of the patron name to be customized in a manner similar to what is done with the DA field on bug 16755. Test Plan: 1) Apply this patch, start or restart your SIP server 2) Find a patron with a first and last name 3) Send a patron information request via the sip2 cli tool 4) Note the AE field has the format "<firstname> <surname>" ( i.e. the current behavior ) 5) Add this parameter to the login stanza you are using: ae_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" 6) Restart your SIP server 7) Repeat step 3 8) Note the AE field now has the format "<surname>, <firstname>" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Benjamin Daeuber <BDaeuber@cityoffargo.com> Created attachment 64579 [details] [review] Bug 18104 - allow SIP2 field AE (personal name ) to be customized Koha's SIP2 server sends the patron's name in the format "Firstname Surname" which is not very good for machine reading. We need to allow the format of the patron name to be customized in a manner similar to what is done with the DA field on bug 16755. Test Plan: 1) Apply this patch, start or restart your SIP server 2) Find a patron with a first and last name 3) Send a patron information request via the sip2 cli tool 4) Note the AE field has the format "<firstname> <surname>" ( i.e. the current behavior ) 5) Add this parameter to the login stanza you are using: ae_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" 6) Restart your SIP server 7) Repeat step 3 8) Note the AE field now has the format "<surname>, <firstname>" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Benjamin Daeuber <BDaeuber@cityoffargo.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 64580 [details] [review] Bug 18104: Add a test for customized name in AE Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 64581 [details] [review] Bug 18104: [QA Follow-up] Add a test for customized name in AE Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |