Bug 18109

Summary: Uncertain prices has no font awesome icon in acquisitions toolbar
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: AcquisitionsAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart+koha, katrin.fischer, kyle, tomascohen, veron
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:
Attachments: toolbar
Bug 18109: Adding font awesome icon to uncertain prices button
Bug 18109: Adding font awesome icon to uncertain prices button
Bug 18109: Adding font awesome icon to uncertain prices button

Description Aleisha Amohia 2017-02-14 01:52:51 UTC
Created attachment 60171 [details]
toolbar

Uncertain prices is the only button with no icon. Looks a bit plain
Comment 1 Aleisha Amohia 2017-02-14 02:15:28 UTC
Created attachment 60172 [details] [review]
Bug 18109: Adding font awesome icon to uncertain prices button

To test:
1) Go to Acquisitions -> search for a vendor
2) View a basket with uncertain prices or add an order with uncertain
prices to a basket
3) Confirm that font awesome icon is appropriate and button still works
as expected

Sponsored-by: Catalyst IT
Comment 2 Marc Véron 2017-02-17 10:30:31 UTC
Created attachment 60391 [details] [review]
Bug 18109: Adding font awesome icon to uncertain prices button

To test:
1) Go to Acquisitions -> search for a vendor
2) View a basket with uncertain prices or add an order with uncertain
prices to a basket
3) Confirm that font awesome icon is appropriate and button still works
as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Jonathan Druart 2017-02-20 08:55:03 UTC
Created attachment 60450 [details] [review]
Bug 18109: Adding font awesome icon to uncertain prices button

To test:
1) Go to Acquisitions -> search for a vendor
2) View a basket with uncertain prices or add an order with uncertain
prices to a basket
3) Confirm that font awesome icon is appropriate and button still works
as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2017-02-21 19:56:48 UTC
Pushed to master for 17.05, thanks Aleisha!
Comment 5 Katrin Fischer 2017-02-21 21:06:18 UTC
This won't get ported back to 16.11.x as it is an enhancement.