|
Description
Nick Clemens (kidclamp)
2017-02-14 16:25:04 UTC
Created attachment 60217 [details] [review] Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup To test: Use a vendor with values in gstrate, listincgst, discount and ensure they are used correctly in plan from 15503 Bug 15503 test plan: 1) Edit the MarcItemFieldsToOrder syspref. For example: homebranch: 975$a holdingbranch: 975$b itype: 975$9|975$z nonpublic_note: 975$x public_note: 975$y loc: 975$8 ccode: 975$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 969$h budget_code: 922$a price: 975$p 2) Create some sample records in koha with values in these fields, then save them as Unicode-UTF-8 Example: 922 _aBudget_code_1 922 _aBudget_code_2 969 _h3 969 _h1 975 _71 _8loc _9CD _aHomebranch_1 _bHoldingbranch_1 _cccode_1 _ncopyno _uuri _xnonpublic_note _ypublic_note _p12.5 975 _70 _8loc2 _aHomebranch_2 _bHoldingbranch_2 _cccode_2 _ncopyno2 _uuri2 _xnonpublic_note2 _ypublic_note2 _zDVD _p22 3) Import your test records with the import tool (Stage MARC records for import) 4) Choose a basket, then click on "Add to basket" => "From a staged file" 5) Choose the file you have imported. For each record that had item informations, you will have a preview of the item that will be created on the left side of the screen. Values can still be modified at this point. Save. 6) Check that the items and corresponding order lines have been created. Created attachment 60249 [details] [review] Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup To test: Use a vendor with values in gstrate, listincgst, discount and ensure they are used correctly in plan from 15503 Bug 15503 test plan: 1) Edit the MarcItemFieldsToOrder syspref. For example: homebranch: 975$a holdingbranch: 975$b itype: 975$9|975$z nonpublic_note: 975$x public_note: 975$y loc: 975$8 ccode: 975$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 969$h budget_code: 922$a price: 975$p 2) Create some sample records in koha with values in these fields, then save them as Unicode-UTF-8 Example: 922 _aBudget_code_1 922 _aBudget_code_2 969 _h3 969 _h1 975 _71 _8loc _9CD _aHomebranch_1 _bHoldingbranch_1 _cccode_1 _ncopyno _uuri _xnonpublic_note _ypublic_note _p12.5 975 _70 _8loc2 _aHomebranch_2 _bHoldingbranch_2 _cccode_2 _ncopyno2 _uuri2 _xnonpublic_note2 _ypublic_note2 _zDVD _p22 3) Import your test records with the import tool (Stage MARC records for import) 4) Choose a basket, then click on "Add to basket" => "From a staged file" 5) Choose the file you have imported. For each record that had item informations, you will have a preview of the item that will be created on the left side of the screen. Values can still be modified at this point. Save. 6) Check that the items and corresponding order lines have been created. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Matts, Any chances to get a signoff on this one? With the patch applied, after validating the items informations, I have a "The method gstrate is not covered by tests!" error message. Created attachment 60811 [details] [review] Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup Fix use of 'gstrate' for 'tax_rate' Created attachment 60834 [details] [review] Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup Fix use of 'gstrate' for 'tax_rate' Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 60888 [details] [review] Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup Fix use of 'gstrate' for 'tax_rate' Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the 17.05 release. Thanks! |