Description
Matthias Meusburger
2017-02-15 07:57:35 UTC
Created attachment 60851 [details] [review] Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions Created attachment 60852 [details] [review] Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Created attachment 61182 [details] [review] Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions Created attachment 61183 [details] [review] Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Created attachment 61587 [details] [review] Bug 18120: (followup) Make operationId unique The last patch "Bug 18120: (followup) Make operationId unique" breaks the tests. Without the last patch, I've tested the endpoint and ran the tests successfully. Created attachment 63146 [details] [review] Bug 18120: (followup) Make operationId unique This patch renames the method names, and the operationID on the swagger spec so they are unique. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 63163 [details] [review] Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 63164 [details] [review] Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 63165 [details] [review] Bug 18120: (followup) Make operationId unique This patch renames the method names, and the operationID on the swagger spec so they are unique. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 66046 [details] [review] Bug 18120 - Changes to some field descriptions Trying to clarify some of the descriptions. I have added a patch with some suggestions for rephrasing/changing the descriptions a bit. Currently this endpoint seems to check for full acquisitions permission: + "permissions": { + "acquisition": "1" + } + } I think we could make this less strict, as we have a separate permission for dealing with vendors: vendors_manage - Manage vendors This would also make it easier if you need the vendors for serials, but don't want to give more access than necessary: Created attachment 66362 [details] [review] Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 66363 [details] [review] Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Patches rebased on top of bug 18137 (OpenAPI). Test plan applies and tests pass. Created attachment 66417 [details] [review] Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 66418 [details] [review] Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Had submitted a follow-up with suggestions - was lost in rebase :( Created attachment 66427 [details] [review] Bug 18120: REST api | /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 66428 [details] [review] Bug 18120: REST api | Add a 'vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 66429 [details] [review] Bug 18120: Update field descriptions Trying to clarify some of the descriptions. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 66430 [details] [review] Bug 18120: (QA followup) 'vendors_manage' permission fits better than full acq Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Please double check POD coverage. Created attachment 67326 [details] [review] Bug 18120: /acquisitions/vendors unit tests This patch introduces unit tests that need to be passed by an /acquisitions/vendors/ REST endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: The endpoint is not present, should fail. Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67327 [details] [review] Bug 18120: Add '/acquisitions/vendors' endpoint This patch introduces an /acquisitions/vendors endpoint. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67328 [details] [review] Bug 18120: Update field descriptions Trying to clarify some of the descriptions. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67329 [details] [review] Bug 18120: (QA followup) 'vendors_manage' permission fits better than full acq Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67330 [details] [review] Bug 18120: (QA followup) Add POD to controler class Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 67490 [details] [review] Bug 18120: Tidy up Pushed to master for 17.11, thanks to everybody involved! New feature not pushed to 17.05.x |