Summary: | Audio alerts: Add hint on where to enable sounds | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | System Administration | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle, mtj, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18122 - Audio alerts: Add hint on where to enable sounds
Bug 18122 - Audio alerts: Add hint on where to enable sounds Bug 18122 - Audio alerts: Add hint on where to enable sounds Bug 18122 - Audio alerts: Add hint on where to enable sounds |
Description
Marc Véron
2017-02-15 09:17:17 UTC
Created attachment 60246 [details] [review] Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. I think the hint on the audio alerts page should be in a <div class="dialog alert"></div> Created attachment 60536 [details] [review] Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv Wow! This is going to save some poor tired soul a lot of headaches. Good job. Created attachment 60571 [details] [review] Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 60640 [details] [review] Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Marc! Helpful string change - decided to push this although it's marked as enhancement. This patch has been pushed to 16.11.x and will be in 16.11.05. Pushed to 16.05.x, for 16.05.11 release |