| Summary: | Add ability to add batch modified records to an existing list | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Tools | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, jonathan.druart, jzairo, martin.renvoize, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
With this enhancement you can add all the records of a batch record modification to an existing list after successful modification.
|
Version(s) released in: |
20.05.00
|
| Circulation function: | |||
| Bug Depends on: | 12759 | ||
| Bug Blocks: | 18133 | ||
| Attachments: |
Bug 18127: Add batch modified records to an existing list
Bug 18127: Add batch modified records to an existing list Bug 18127: Add batch modified records to an existing list Bug 18127: Add batch modified records to an existing list Bug 18127: Add batch modified records to an existing list Bug 18127: Add missing html filters |
||
|
Description
Aleisha Amohia
2017-02-16 02:14:41 UTC
Created attachment 60299 [details] [review] Bug 18127: Add batch modified records to an existing list This patch is based off a suggestion from bug 12759 to allow a user to add records to a list after they have been batch modified. To test: 1) Apply 12759 2) Pick a list to modify, go through batch modification process 3) Once the modification is done and successful, there should now be a 'Next' box with options in it 4) Confirm the 'New batch record modification' button takes you back to the start of the process. 5) Repeat step 2 6) Select a list from the dropdown to add your records to 7) Confirm that the correct records show in the pop up window 8) Once saved, go to your lists and confirm unique records were saved to the list Sponsored-by: Catalyst IT Created attachment 60366 [details] [review] Bug 18127: Add batch modified records to an existing list This patch is based off a suggestion from bug 12759 to allow a user to add records to a list after they have been batch modified. To test: 1) Apply 12759 2) Pick a list to modify, go through batch modification process 3) Once the modification is done and successful, there should now be a 'Next' box with options in it 4) Confirm the 'New batch record modification' button takes you back to the start of the process. 5) Repeat step 2 6) Select a list from the dropdown to add your records to 7) Confirm that the correct records show in the pop up window 8) Once saved, go to your lists and confirm unique records were saved to the list 9) Go back to batch record modifications 10) Select Authorities as the record type. Enter an authority id in the record number list. Click Continue 11) Click modify selected records 12) Confirm that there is no dropdown to add to lists (since you can't add authorities to lists) and the link to New batch record modification works as expected. Sponsored-by: Catalyst IT Created attachment 98422 [details] [review] Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT Created attachment 98971 [details] [review] Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Hi Aleisha, A couple of things: 1. After 7, I still have the "Add to a list:" popup that does not close. I think that is not correct. 2. I am wondering how we could improve the ergonomic of the last view, maybe Owen could help us? https://snipboard.io/GYxbaS.jpg Especially if there is no list, we see """ Next steps: * New batch record modification """ (In reply to Jonathan Druart from comment #6) > Hi Aleisha, > > A couple of things: > > 1. After 7, I still have the "Add to a list:" popup that does not close. I > think that is not correct. > Hi Jonathan. I don't get this bug - The popup closes when you click 'Save' and when you click 'Cancel'. When I select a list, the popup is displayed with /cgi-bin/koha/virtualshelves/addbybiblionumber.pl?shelfnumber=4&confirm=1&biblionumber=1&biblionumber=2&biblionumber=3&biblionumber=4&biblionumber=5 I then click "Save", the popup reloads with /cgi-bin/koha/virtualshelves/addbybiblionumber.pl and I see https://snipboard.io/lGR2fE.jpg Sorry Jonathan I'm still unable to reproduce that, and I've asked others to test and they couldn't reproduce either. Setting back to Needs signoff to see if this is working (or not working) for someone else. Could this be a browser issue? I seem to remember we had issues with 'not closing windows' on another bug report a while ago. Which browsers have you 2 been testing with? Ok with Chromium, Not OK with Firefox. I indeed see <html><meta http-equiv="refresh" content="0" /><body onload="self.close();"></body></html> in the source, but the window does not close. Same behavior when adding a record to a list from the search result page actually, so not (directly) related to this. (In reply to Jonathan Druart from comment #11) > Ok with Chromium, Not OK with Firefox. > > I indeed see > <html><meta http-equiv="refresh" content="0" /><body > onload="self.close();"></body></html> > in the source, but the window does not close. Same behavior when adding a > record to a list from the search result page actually, so not (directly) > related to this. Well, I am confused. It works in FF in a private window, I guess I have an extension that is missing with that close(). Sorry! Thanks anyway Jonathan. I am testing in Firefox and it works fine for me. Will leave as Needs signoff for someone else to test. Created attachment 100449 [details] [review] Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100450 [details] [review] Bug 18127: Add missing html filters Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> That works, and could be considered a first step. IMO the ergonomic should be improved on a follow-up bug report. Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |
