Summary: | Show internal and vendor notes for received orders | ||
---|---|---|---|
Product: | Koha | Reporter: | Alexandre <alexandre.breton> |
Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, jose-mario.monteiro-santos, josef.moravec, lucas, martin.renvoize, nick, patrick.robitaille |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement makes internal and vendor notes visible for received orders. Previously these were only shown for pending orders.
|
Version(s) released in: | |
Circulation function: | |||
Attachments: |
No notes for already received orders
Bug 18166: Show internal and vendor notes for receivied orders Bug 18166: Show internal and vendor notes for receivied orders Bug 18166: Show internal and vendor notes for receivied orders |
Hi, Long story short, the internal and vendor notes will simply disappear after an order was received. However, these notes remain usefull after reception. Thanks for helping, Alexandre from CCSR Created attachment 84949 [details] [review] Bug 18166: Show internal and vendor notes for receivied orders This copies the logic for showing, adding and editing vendor and internal notes from the pending orders to the received orders. To test: - In acquisitions create a basket with orders - Make your you have some internal and vendor notes - Close the basket and receive shipment - Create or reuse an invoice - Receive some of your orders - Verify that the notes don't show for received orders - Apply patch - Verify that the edit/change vendor/internal note links work the same on pending and received orders Created attachment 85188 [details] [review] Bug 18166: Show internal and vendor notes for receivied orders This copies the logic for showing, adding and editing vendor and internal notes from the pending orders to the received orders. To test: - In acquisitions create a basket with orders - Make your you have some internal and vendor notes - Close the basket and receive shipment - Create or reuse an invoice - Receive some of your orders - Verify that the notes don't show for received orders - Apply patch - Verify that the edit/change vendor/internal note links work the same on pending and received orders Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Created attachment 85329 [details] [review] Bug 18166: Show internal and vendor notes for receivied orders This copies the logic for showing, adding and editing vendor and internal notes from the pending orders to the received orders. To test: - In acquisitions create a basket with orders - Make your you have some internal and vendor notes - Close the basket and receive shipment - Create or reuse an invoice - Receive some of your orders - Verify that the notes don't show for received orders - Apply patch - Verify that the edit/change vendor/internal note links work the same on pending and received orders Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 backported to 18.05.x for 18.05.11 |
Created attachment 60623 [details] No notes for already received orders Hi, someone have reported something like a minor bug. 1) Go to acquisition module 2) Make a vendor search, Amazon for example 3) Create a new basket for it 4) Create a new order in it 5) Add an internal and a vendor note and save them 6) Close your basket 7) Return to the vendor basket(s) page and clic on "Receive shipment", then clic on your order on the board and clic on "Finish receiving" 8) Create a new invoice for the order (complete "Vendor invoice", "Shipping cost" and "Shipping fund"), clic "Next" and then clic "Save" 9) Return to "Pending orders" board to observe that internal and vendor infos appear 10) Clic on "Receipt" the order on the right 11) Clic on the "Receive?" case and save 11) The system will return on Receipt summary page and observe that the said infos don't appear anymore on the "Already received" board These notes are usefull to staff clients when they make a fast check up on received orders.