|
Description
Lisette Scheer
2017-02-24 21:00:52 UTC
+1 +1 ;-) This would be very helpful. Created attachment 110703 [details] [review] Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins I had a go at this, please let me know if it works for you :) Created attachment 110705 [details] [review] Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Worked great for me! Damaged status showed in the due date box on the check in screen just like it does on the check out screen. Thanks! Lisette Like asked in Bug 21883 we need to pass item object to page. Also from Bug 26323 we avoid using directly AV category. I think no need to put this In Discussion here - I can fix the hardcoded Authorised value, but I think changing it all to work on an items object is a little too big for me. Can we agree to handle that separately? I also still think we make our lives too hard by not relying on some hardcoded Authorised value codes - documentation and all are refering to them and it makes life tons easier. And: we do have hardocded ones outside of catalouging already. But I have said so on the other bug already. ;) (In reply to Katrin Fischer from comment #9) > I think no need to put this In Discussion here - I can fix the hardcoded > Authorised value, but I think changing it all to work on an items object is > a little too big for me. Can we agree to handle that separately? Totally agree. And my mistake, this patch impacts items in history table, Bug 21883 impacts item currently returned. So not exactly the same. I hope we can push both bugs before refactoring with item object. ;) Hmm, as much as I can see the argument for refactoring this to return an items resultset (or a checkouts resultset really) for code clarity I get the distinct feeling it could have a detrimental effect on performance too (i.e right now we fetch the details once, then pass what we need back and fourth in the template and controller.. such a refactor would mean passing back just a list of ID's and then refecthing the data from the database with each action.. unless I'm missing an way to not require that). In short.. I think this one should move as is. Sooo... on the QA front.. I have an alternate failure I'm afraid. We need to use the KohaField version of the template plugin I think to ensure we get the right mapped AV set. Created attachment 111041 [details] [review] Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 111042 [details] [review] Bug 18170: Use GetDescriptionByKohaField Thank you, Martin, I didn't get around to it yet. Created attachment 111639 [details] [review] Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 111640 [details] [review] Bug 18170: Use GetDescriptionByKohaField Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signing Martin's follow-up - the original patch has an external sign-off. Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |