Bug 18172

Summary: Logged in user page shows internal server error if OverDriveCirculation is disabled
Product: Koha Reporter: Liz Rea <liz>
Component: OPACAssignee: Liz Rea <liz>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: mtj, veron
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 16034    
Bug Blocks:    
Attachments: Bug 18172 - Disabled Overdrive shows error on logged in user page
Bug 18172 - Disabled Overdrive shows error on logged in user page

Description Liz Rea 2017-02-27 00:45:34 UTC
It looks like the Overdrive js and one of the Overdrive divs are being shown in the OPAC logged in user page when overdrive is disabled. This causes an error in the log, and displays a message on the logged in user screen where Overdrive is supposed to put whatever it's getting from the API. 

This is in the log: 
OverDriveClientKey pref not set at /home/vagrant/kohaclone/opac/svc/overdrive line 38.
Comment 1 Liz Rea 2017-02-27 01:06:00 UTC
I have a patch for this but I can't seem to attach it, seems the server is out of space.
Comment 2 Liz Rea 2017-02-28 20:21:26 UTC
Created attachment 60739 [details] [review]
Bug 18172 - Disabled Overdrive shows error on logged in user page

To test:
Have overdrive disabled (default state)
log into the OPAC (I did it with plack) note the error just below the
tabs on the page.
Note that the overdrive JS is being fetched/included
Apply this patch
Restart plack/memcached
refresh the page, note that the error is gone.
Also note that the JS for Overdrive is no longer being fetched/included.
Comment 3 Liz Rea 2017-02-28 20:22:29 UTC
Comment on attachment 60739 [details] [review]
Bug 18172 - Disabled Overdrive shows error on logged in user page

oops, something snuck in that shouldn't be there. Try again.
Comment 4 Liz Rea 2017-02-28 20:24:15 UTC
Created attachment 60740 [details] [review]
Bug 18172 - Disabled Overdrive shows error on logged in user page

To test:
Have overdrive disabled (default state)
    log into the OPAC (I did it with plack) note the error just below
    the
    tabs on the page.
    Note that the overdrive JS is being fetched/included
    Apply this patch
    Restart plack/memcached
    refresh the page, note that the error is gone.
    Also note that the JS for Overdrive is no longer being
    fetched/included.
Comment 5 Marc VĂ©ron 2017-04-06 12:09:50 UTC
Sorry, patch does not apply (merge conflict in opac-user.tt).