Summary: | Remove issues.return | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18173: Remove DB field issues.return
Bug 18173: Remove DB field issues.return Bug 18173: Remove DB field issues.return Bug 18173: Remove DB field issues.return Bug 18173: DBIx schema changes |
Description
Jonathan Druart
2017-02-27 09:37:59 UTC
Created attachment 60696 [details] [review] Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Created attachment 60828 [details] [review] Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger <magnus@libriotech.no> I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. Created attachment 60829 [details] [review] Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger <magnus@libriotech.no> I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. Looking around for return: offline_circ/process_koc.pl: 'return' => \&kocReturnItem, Definitely a bad choice for a hash key, but not relevant here. From bug 16034 / Koha/ExternalContent/OverDrive.pm: =item C<return($id)> opac/svc/overdrive: $data{action} = eval { $od->return($id) }; A method called return ;) Not relevant too here. Found nothing special with ->return or {return too. Created attachment 60870 [details] [review] Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger <magnus@libriotech.no> I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 60871 [details] [review] Bug 18173: DBIx schema changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Jonathan, Marcel! This won't get ported back to 16.11.x as it is an enhancement. |