| Summary: | MARC21: Further improve handling of 5XX$u in GetMarcNotes | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | MARC Bibliographic data support | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, nick |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes
Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes Bug 18198: (QA follow-up) Add tests for GetMarcNotes |
||
|
Description
Marcel de Rooy
2017-03-02 11:58:54 UTC
Created attachment 60790 [details] [review] Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes Bug 14306 only handled field 555 in MARC21 as an URI. But a lot of other 5XX fields have a $u subfield for URIs; actually $u is not used in any other way. This patch generalizes the change made for 555 and extends it to all 5XX $u. Test plan: [1] Run t/Biblio.t [2] Run t/db_dependent/Biblio.t [3] Edit a MARC21 record. Add a URL into 505u, 520u, 555u. [4] Check presentation on opac-detail (tab Title notes) [5] Check presentation on catalogue/detail (tab Descriptions) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 68170 [details] [review] Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes Bug 14306 only handled field 555 in MARC21 as an URI. But a lot of other 5XX fields have a $u subfield for URIs; actually $u is not used in any other way. This patch generalizes the change made for 555 and extends it to all 5XX $u. Test plan: [1] Run t/Biblio.t [2] Run t/db_dependent/Biblio.t [3] Edit a MARC21 record. Add a URL into 505u, 520u, 555u. [4] Check presentation on opac-detail (tab Title notes) [5] Check presentation on catalogue/detail (tab Descriptions) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #2) > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thanks ! Created attachment 70941 [details] [review] Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes Bug 14306 only handled field 555 in MARC21 as an URI. But a lot of other 5XX fields have a $u subfield for URIs; actually $u is not used in any other way. This patch generalizes the change made for 555 and extends it to all 5XX $u. Test plan: [1] Run t/Biblio.t [2] Run t/db_dependent/Biblio.t [3] Edit a MARC21 record. Add a URL into 505u, 520u, 555u. [4] Check presentation on opac-detail (tab Title notes) [5] Check presentation on catalogue/detail (tab Descriptions) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> (In reply to Josef Moravec from comment #4) > Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Great Please provide tests. Created attachment 71085 [details] [review] Bug 18198: (QA follow-up) Add tests for GetMarcNotes As requested by the RM, this patch adds a separate unit test for GetMarcNotes. We test MARC21 and UNIMARC. The NotesBlacklist pref is tested and also handling URLs in 5XX$u for MARC21. Test plan: Run t/Biblio/GetMarcNotes.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Enhancement not backported to stable. |