| Summary: | Authority searches are not saved in Search history | ||
|---|---|---|---|
| Product: | Koha | Reporter: | leire |
| Component: | OPAC | Assignee: | leire |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart, julian.maurice, kyle, mtj, veron |
| Version: | Main | ||
| Hardware: | PC | ||
| OS: | Windows | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 2735 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18204
Bug 18204 - Authority searches are not saved in Search history [SIGNED OFF] Bug 18204 - Authority searches are not saved in Search history Bug 18204 - Authority searches are not saved in Search history |
||
|
Description
leire
2017-03-03 12:40:45 UTC
Created attachment 60809 [details] [review] Bug 18204 Problem recreated.
However, I can not apply the patch:
git bz apply 18204
Result:
Traceback (most recent call last):
File "/usr/local/bin/git-bz", line 2630, in <module>
do_apply(*args)
File "/usr/local/bin/git-bz", line 1755, in do_apply
users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users']
File "/usr/lib/python2.7/xmlrpclib.py", line 1233, in __call__
return self.__send(self.__name, args)
File "/usr/lib/python2.7/xmlrpclib.py", line 1591, in __request
verbose=self.__verbose
File "/usr/lib/python2.7/xmlrpclib.py", line 1273, in request
return self.single_request(host, handler, request_body, verbose)
File "/usr/lib/python2.7/xmlrpclib.py", line 1321, in single_request
response.msg,
xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found>
Created attachment 63387 [details] [review] Bug 18204 - Authority searches are not saved in Search history When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" Created attachment 63398 [details] [review] [SIGNED OFF] Bug 18204 - Authority searches are not saved in Search history When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi, thx for the patch! Is this a first? I have noticed the author line reads: From: LeireDiez <leire@scanbit.net> Is this how you want it? The names will show up on the dashboard and in the release notes :) Hi, Yes, it's my first patch! But my plan is to upload fixes that I will solve. My name is Leire Díez, I've seen that it usually shows up the person's name and last name, so I think that's fine. Thanks you! Created attachment 63424 [details] [review] Bug 18204 - Authority searches are not saved in Search history When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 17.05, thanks Leire! This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |