Summary: | Resolve warning on $tls in Database.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, kyle, m.de.rooy, mtompset, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15427 | ||
Bug Blocks: | |||
Attachments: |
Bug 18215: Resolve warning on $tls in Database.pm
Bug 18215: Resolve warning on $tls in Database.pm Bug 18215: Resolve warning on $tls in Database.pm [PUSHED] Bug 18215: Resolve warning on $tls in Database.pm Bug 18215: Fix another tls warning Bug 18215: Third case which was missed. |
Description
Marcel de Rooy
2017-03-06 09:40:04 UTC
Created attachment 60823 [details] [review] Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. Created attachment 60832 [details] [review] Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. Signed-off-by: Magnus Enger <magnus@libriotech.no> Warning disappears after applying the patch. Created attachment 60844 [details] [review] Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. Signed-off-by: Magnus Enger <magnus@libriotech.no> Warning disappears after applying the patch. Pushed to master for 17.05, thanks Marcel! Created attachment 60846 [details] [review] [PUSHED] Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. Signed-off-by: Magnus Enger <magnus@libriotech.no> Warning disappears after applying the patch. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 60975 [details] [review] Bug 18215: Fix another tls warning Resolve warning: Use of uninitialized value in string eq at C4/Installer.pm line 79. Test plan: Add a trivial .sql file in atomicupdate (comment is sufficient). Run updatedatabase.pl Without the patch you have the warning. Apply the patch and repeat (no warning). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Kyle: Please push the second patch. The problem is that kohastructures.sql is LACKING a TLS. Created attachment 61005 [details] [review] Bug 18215: Third case which was missed. Git install old-school style a pre-tls koha Drop the DB Create the DB change branch to master Run a web install. NOTE: found with git grep "['\"]tls['\"]" Depends on enh bug 15427 that is not in 16.11.x. Katrin: This was Passed QA. So you should not close it. Just wait until all patches have been pushed and the status has been changed. Sorry, missed that you weren't finished here when looking over this. Pushed the following two followups.. Brendan Depends on bug 15427 which is not in 16.11.x. |