| Summary: | Fix tests broken by Bug 18026 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
| Component: | Test Suite | Assignee: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 18026 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18222 - Fix tests broken by Buug 18026
Bug 18222 - Fix tests broken by Buug 18026 Bug 18222 - Fix tests broken by Buug 18026 |
||
Created attachment 60865 [details] [review] Bug 18222 - Fix tests broken by Buug 18026 root@koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 1..2 ok 1 - Correct development version ok 2 - Correct maintenance version ok 3 - Koha::Template::Plugin::Koha::Version tests Created attachment 60868 [details] [review] Bug 18222 - Fix tests broken by Buug 18026 root@koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 1..2 ok 1 - Correct development version ok 2 - Correct maintenance version ok 3 - Koha::Template::Plugin::Koha::Version tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Combining SO and QA here Passed QA Created attachment 60869 [details] [review] Bug 18222 - Fix tests broken by Buug 18026 root@koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 1..2 ok 1 - Correct development version ok 2 - Correct maintenance version ok 3 - Koha::Template::Plugin::Koha::Version tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Marcel de Rooy from comment #3) > Combining SO and QA here > Passed QA Did not see it, I was going to do the same :) This appears to have been pushed to master already? perl t/Koha_Template_Plugin_Koha.t passes on 16.11.x - so I think this is not needed there. Also pushed to master - switching status. No, it's not pushed yet. Yes it is!! |
root@koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 # Subtest: Koha::Template::Plugin::Koha::Version tests 1..2 not ok 1 - Correct development version # Failed test 'Correct development version' # at t/Koha_Template_Plugin_Koha.t line 54. # Structures begin differing at: # $got->{minor} = '24' # $expected->{minor} = Does not exist not ok 2 - Correct maintenance version # Failed test 'Correct maintenance version' # at t/Koha_Template_Plugin_Koha.t line 69. # Structures begin differing at: # $got->{minor} = '07' # $expected->{minor} = Does not exist # Looks like you failed 2 tests of 2. not ok 3 - Koha::Template::Plugin::Koha::Version tests # Failed test 'Koha::Template::Plugin::Koha::Version tests' # at t/Koha_Template_Plugin_Koha.t line 76. # Looks like you failed 1 test of 3.