|
Description
Olli-Antti Kivilahti
2017-03-08 10:49:53 UTC
Created attachment 60912 [details] [review] Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print" No more wide characters in print when logging to a file with Koha::Logger. Test with this string "♯Turpo :" Patch no longer applies (missing dependency?): Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print" fatal: sha1 information is lacking or useless (etc/log4perl.conf). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print" The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18227---KohaLogger-utf8-handling-defeating-wid-VJmYgV.patch Assigning to Olli-Antti as he provided the patch. Created attachment 102167 [details] [review] Bug 18227: Handle utf8 in Koha::Logger No more wide characters in print when logging to a file with Koha::Logger. Test with this string "♯Turpo :" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 102168 [details] [review] Bug 18227: (QA follow-up) Add fix to koha-common.postinst Now koha-common.postinst has a way to patch log4perl configs on instances, we should patch the Z3950 responder config accordingly, before it is backported to 19.11 or the 20.05 release :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I changed the dependency the other way so this has the chance to get pushed faster. This is important as my follow-up is patching something that hasn't hit stable yet (koha-common.postinst) and if the 19.11 rmaint is willing to backport bug 24905, this needs to be fixed for backporting, otherwise patching production Koha will be really tricky. Created attachment 102223 [details] [review] Bug 18227: Handle utf8 in Koha::Logger No more wide characters in print when logging to a file with Koha::Logger. Test with this string "♯Turpo :" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 102224 [details] [review] Bug 18227: (QA follow-up) Add fix to koha-common.postinst Now koha-common.postinst has a way to patch log4perl configs on instances, we should patch the Z3950 responder config accordingly, before it is backported to 19.11 or the 20.05 release :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.06 missing dependencies for 19.05.x, no backport |