| Summary: | Remove C4::Items::GetItemsByBiblioitemnumber call from additem.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, kyle |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 18253 | ||
| Attachments: |
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl |
||
|
Description
Jonathan Druart
2017-03-13 15:20:34 UTC
Created attachment 61041 [details] [review] Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl The code from additem to delete all the items of a bibliographic record is very ackward. This patch simplifies the algorithm and make the code more readable. Test plan: Remove all the items of a bibliographic records If at least 1 item is checked out you should get an error. No change with the current behavior is expected. Created attachment 62207 [details] [review] Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl The code from additem to delete all the items of a bibliographic record is very ackward. This patch simplifies the algorithm and make the code more readable. Test plan: Remove all the items of a bibliographic records If at least 1 item is checked out you should get an error. No change with the current behavior is expected. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Created attachment 64329 [details] [review] Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl The code from additem to delete all the items of a bibliographic record is very ackward. This patch simplifies the algorithm and make the code more readable. Test plan: Remove all the items of a bibliographic records If at least 1 item is checked out you should get an error. No change with the current behavior is expected. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |