Bug 18254

Summary: Remove C4::Items::GetItemsByBiblioitemnumber call from additem.pl
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, kyle
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: ---
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Bug Depends on:    
Bug Blocks: 18253    
Attachments: Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl

Description Jonathan Druart 2017-03-13 15:20:34 UTC

    
Comment 1 Jonathan Druart 2017-03-13 15:29:06 UTC
Created attachment 61041 [details] [review]
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl

The code from additem to delete all the items of a bibliographic record
is very ackward.
This patch simplifies the algorithm and make the code more readable.

Test plan:
Remove all the items of a bibliographic records
If at least 1 item is checked out you should get an error.

No change with the current behavior is expected.
Comment 2 Alex Buckley 2017-04-17 09:56:42 UTC
Created attachment 62207 [details] [review]
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl

The code from additem to delete all the items of a bibliographic record
is very ackward.
This patch simplifies the algorithm and make the code more readable.

Test plan:
Remove all the items of a bibliographic records
If at least 1 item is checked out you should get an error.

No change with the current behavior is expected.

Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Comment 3 Kyle M Hall 2017-06-15 14:31:53 UTC
Created attachment 64329 [details] [review]
Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl

The code from additem to delete all the items of a bibliographic record
is very ackward.
This patch simplifies the algorithm and make the code more readable.

Test plan:
Remove all the items of a bibliographic records
If at least 1 item is checked out you should get an error.

No change with the current behavior is expected.

Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-06-15 19:08:44 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin SOMERS 2017-06-20 08:31:33 UTC
Enhancement not pushed to 17.05.x