Summary: | Koha::Biblio - Remove GetBiblioItemByBiblioNumber | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 17628, 21203 | ||
Attachments: |
Bug 18255: WIP
Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem |
Description
Jonathan Druart
2017-03-13 16:42:37 UTC
Created attachment 61043 [details] [review] Bug 18255: WIP Waiting for an answer from the mailing list - http://lists.koha-community.org/pipermail/koha-devel/2017-March/043530.html Created attachment 70379 [details] [review] Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem The subroutine GetBiblioItemByBiblioNumber considers that we have a 1-N relation between biblio and biblioitems, which is wrong (it's 1-1). So the calls can be replaced with Koha::biblio->biblioitem, it will ease the read of the code. Test plan: 1. Use the ILSDI service to display info of a bibliographic record, biblioitems fields must be displayed 2. Search for items, biblioitems info must be displayed as well in the result table (In reply to Jonathan Druart from comment #2) > Waiting for an answer from the mailing list - > http://lists.koha-community.org/pipermail/koha-devel/2017-March/043530.html I am not sure to understand why I sent this email, the $bibitems parameter of AddReserve is not used. Created attachment 72571 [details] [review] Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem The subroutine GetBiblioItemByBiblioNumber considers that we have a 1-N relation between biblio and biblioitems, which is wrong (it's 1-1). So the calls can be replaced with Koha::biblio->biblioitem, it will ease the read of the code. Test plan: 1. Use the ILSDI service to display info of a bibliographic record, biblioitems fields must be displayed 2. Search for items, biblioitems info must be displayed as well in the result table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 72604 [details] [review] Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem The subroutine GetBiblioItemByBiblioNumber considers that we have a 1-N relation between biblio and biblioitems, which is wrong (it's 1-1). So the calls can be replaced with Koha::biblio->biblioitem, it will ease the read of the code. Test plan: 1. Use the ILSDI service to display info of a bibliographic record, biblioitems fields must be displayed 2. Search for items, biblioitems info must be displayed as well in the result table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 18.05, thanks to everybody involved! Enhancement, not backported for 17.11 |