Summary: | Koha::Biblio - Remove GetSubscriptionsId | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18256, 18258 | ||
Bug Blocks: | 17628 | ||
Attachments: |
Bug 18259: Koha::Biblio - Remove GetSubscriptionsId
[SIGNED-OFF] Bug 18259: Koha::Biblio - Remove GetSubscriptionsId Bug 18259: Koha::Biblio - Remove GetSubscriptionsId Bug 18259: Koha::Biblio - Remove GetSubscriptionsId Bug 18259: [QA Follow-up] Replace variable name Bug 18259: Koha::Biblio - Remove GetSubscriptionsId Bug 18259: [QA Follow-up] Replace variable name |
Description
Jonathan Druart
2017-03-13 18:32:40 UTC
Created attachment 61051 [details] [review] Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Created attachment 63889 [details] [review] [SIGNED-OFF] Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 64826 [details] [review] Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 65041 [details] [review] Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 65042 [details] [review] Bug 18259: [QA Follow-up] Replace variable name The variable name has_subscriptions implies that it is a boolean. In reality we save the number of subscriptions into it. Renaming has_ to cnt_. Created attachment 65043 [details] [review] Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 65044 [details] [review] Bug 18259: [QA Follow-up] Replace variable name The variable name has_subscriptions implies that it is a boolean. In reality we save the number of subscriptions into it. Renaming has_ to cnt_. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Enhancement not pushed to 17.05.x |