Bug 18263

Summary: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables
Product: Koha Reporter: Marc Véron <veron>
Component: PatronsAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, julian.maurice, katrin.fischer, kyle.m.hall, kyle, mirko, mtj
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables
Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables
Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables

Description Marc Véron 2017-03-14 13:13:18 UTC
On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for..., make the amounts display as defined in syspref 'CurrencyFormat'
Comment 1 Marc Véron 2017-03-14 13:34:02 UTC
Created attachment 61066 [details] [review]
Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables

On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for...,
make the amounts display as defined in syspref 'CurrencyFormat'

To test:
- Apply patch
- Give a patron a high fine or credit (e.g. 12345.67)
- Got to pages Home > Patrons > Accounts for... and
  Home > Patrons > Pay fines
- Verify that amounts display following syspref 'CurrencyFormat'
  (e.g. 12'345.67 for syspref set to 360'000.00 (CH)
Comment 2 Mirko Tietgen 2017-03-20 13:43:57 UTC
Created attachment 61300 [details] [review]
Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables

On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for...,
make the amounts display as defined in syspref 'CurrencyFormat'

To test:
- Apply patch
- Give a patron a high fine or credit (e.g. 12345.67)
- Got to pages Home > Patrons > Accounts for... and
  Home > Patrons > Pay fines
- Verify that amounts display following syspref 'CurrencyFormat'
  (e.g. 12'345.67 for syspref set to 360'000.00 (CH)

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Comment 3 Jonathan Druart 2017-03-21 11:50:29 UTC
Created attachment 61373 [details] [review]
Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables

On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for...,
make the amounts display as defined in syspref 'CurrencyFormat'

To test:
- Apply patch
- Give a patron a high fine or credit (e.g. 12345.67)
- Got to pages Home > Patrons > Accounts for... and
  Home > Patrons > Pay fines
- Verify that amounts display following syspref 'CurrencyFormat'
  (e.g. 12'345.67 for syspref set to 360'000.00 (CH)

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2017-03-31 14:28:28 UTC
Pushed to master for 17.05, thanks Marc!
Comment 5 Katrin Fischer 2017-04-02 17:37:43 UTC
Hm, this could also be seen as an enhancement to the current views. In sake of more consistency in this part of Koha, I am pushing this to 16.11.x to be in 16.11.07.
Comment 6 Julian Maurice 2017-04-21 10:29:27 UTC
Pushed to 3.22.x for 3.22.20
Comment 7 Mason James 2017-05-03 04:07:07 UTC
Pushed to 16.05.x, for 16.05.12 release