| Summary: | No need to fetch the MARC record when deleting an item | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, martin.renvoize, veron |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18270: Do not fetch the MARC record when deleting an item
Bug 18270: Do not fetch the MARC record when deleting an item Bug 18270: Do not fetch the MARC record when deleting an item |
||
Created attachment 61100 [details] [review] Bug 18270: Do not fetch the MARC record when deleting an item $record is never used later, the call is superfluous. Test plan: Quick glance at the code should be enough Created attachment 61103 [details] [review] Bug 18270: Do not fetch the MARC record when deleting an item $record is never used later, the call is superfluous. Test plan: Quick glance at the code should be enough Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 61286 [details] [review] Bug 18270: Do not fetch the MARC record when deleting an item $record is never used later, the call is superfluous. Test plan: Quick glance at the code should be enough Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed to master for 17.05, thanks Jonathan! Code enhancement. This won't get ported back to 16.11.x as it is an enhancement. |
From C4::Items::DelItem 683 # get the MARC record 684 my $record = GetMarcBiblio($biblionumber); 685 ModZebra( $biblionumber, "specialUpdate", "biblioserver" ); 686 687 #search item field code 688 logaction("CATALOGUING", "DELETE", $itemnumber, "item") if C4::Context->preference("CataloguingLog"); 689 return $deleted; 690 } The GetMarcBiblio call is not needed.