| Summary: | jquery.fixFloat.js breaks advanced MARC editor for some browsers | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Gustafsson <glasklas> |
| Component: | Cataloging | Assignee: | David Gustafsson <glasklas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | brendan, jonathan.druart, lucy.vaux-harvey, m.de.rooy, magnus, mirko, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 16400 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor
Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor |
||
Created attachment 61303 [details] [review] Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). *** Bug 17878 has been marked as a duplicate of this bug. *** Created attachment 61474 [details] [review] Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 61488 [details] [review] Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the 17.05 release. Thanks! Great! Thanks for the quick response! Thanks for the patch David! This patch has been pushed to 16.11.x and will be in 16.11.06. *** Bug 18353 has been marked as a duplicate of this bug. *** Pushed to 16.05.x, for 16.05.12 release |
Get the following errors editing a bibliographic record: "Uncaught SyntaxError: Unexpected token =" and "addbiblio.pl:294 Uncaught TypeError: $(...).fixFloat is not a function" which breaks the advanced MARC editor (and potentially other things as well). This is caused by the following line in koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.fixFloat.js: "$.fn.fixFloat = function (options={}) {" I'm running Chromium 47 which does not support parameter defaults (added in 49). Internet Explorer (besides edge) and Opera has no support. Since everything seems to work fine when fixing this it seems a shame to let this minor snippet screw up support for so many browser versions.