Summary: | jquery.fixFloat.js breaks advanced MARC editor for some browsers | ||
---|---|---|---|
Product: | Koha | Reporter: | David Gustafsson <glasklas> |
Component: | Cataloging | Assignee: | David Gustafsson <glasklas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | brendan, jonathan.druart, katrin.fischer, lucy.vaux-harvey, m.de.rooy, magnus, mirko, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 16400 | ||
Bug Blocks: | |||
Attachments: |
Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor
Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor |
Description
David Gustafsson
2017-03-20 14:08:25 UTC
Created attachment 61303 [details] [review] Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). *** Bug 17878 has been marked as a duplicate of this bug. *** Created attachment 61474 [details] [review] Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 61488 [details] [review] Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the 17.05 release. Thanks! Great! Thanks for the quick response! Thanks for the patch David! This patch has been pushed to 16.11.x and will be in 16.11.06. *** Bug 18353 has been marked as a duplicate of this bug. *** Pushed to 16.05.x, for 16.05.12 release |