| Summary: | Branchname is no longer displayed in subscription tab view | ||
|---|---|---|---|
| Product: | Koha | Reporter: | jmbroust <jean-manuel.broust> |
| Component: | OPAC | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle, mtj, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15758, 17946 | ||
| Bug Blocks: | |||
| Attachments: |
library name not displayed in opac detail subscription tab
Bug 18307 - Branchname is no more displayed in subscription tab wiew Bug 18307 - Branchname is no more displayed in subscription tab wiew Bug 18307 - Branchname is no more displayed in subscription tab wiew |
||
I can reproduce the problem on current master. Created attachment 61389 [details] [review] Bug 18307 - Branchname is no more displayed in subscription tab wiew This patch restores the branchname in OPAC subscription detail view. Additionally, it adds the subscriptons count to the tab title to make it consistent with the other tab titles. To test: - Search a subscription in OPAC catalog - Go to Subscriptions tab (see screenshot in initial comment) - Verify that library name does not display - Apply patch - Verify that library name displays properly in Subscriptons tab - Verify that the tab title displays the subscriptions count e.g.: Subscriptions (2) Created attachment 61441 [details] [review] Bug 18307 - Branchname is no more displayed in subscription tab wiew This patch restores the branchname in OPAC subscription detail view. Additionally, it adds the subscriptons count to the tab title to make it consistent with the other tab titles. To test: - Search a subscription in OPAC catalog - Go to Subscriptions tab (see screenshot in initial comment) - Verify that library name does not display - Apply patch - Verify that library name displays properly in Subscriptons tab - Verify that the tab title displays the subscriptions count e.g.: Subscriptions (2) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 61459 [details] [review] Bug 18307 - Branchname is no more displayed in subscription tab wiew This patch restores the branchname in OPAC subscription detail view. Additionally, it adds the subscriptons count to the tab title to make it consistent with the other tab titles. To test: - Search a subscription in OPAC catalog - Go to Subscriptions tab (see screenshot in initial comment) - Verify that library name does not display - Apply patch - Verify that library name displays properly in Subscriptons tab - Verify that the tab title displays the subscriptions count e.g.: Subscriptions (2) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Marc! This patch has been pushed to 16.11.x and will be in 16.11.07. (In reply to Katrin Fischer from comment #8) > This patch has been pushed to 16.11.x and will be in 16.11.07. Blocked by Enhancement, skipping for 16.05.x (In reply to Mason James from comment #9) > (In reply to Katrin Fischer from comment #8) > > This patch has been pushed to 16.11.x and will be in 16.11.07. > > Blocked by Enhancement, skipping for 16.05.x hi Katrin, 16.11.x may need patch BZ-17946 now (In reply to Mason James from comment #10) > (In reply to Mason James from comment #9) > > (In reply to Katrin Fischer from comment #8) > > > This patch has been pushed to 16.11.x and will be in 16.11.07. > > > > Blocked by Enhancement, skipping for 16.05.x > > hi Katrin, 16.11.x may need patch BZ-17946 now Hi Mason, I checked, there is a dependency noted, but the patch works without bug 17946 which is marked enhancement. |
Created attachment 61354 [details] library name not displayed in opac detail subscription tab The library name is no more displayed in opac-detail.pl's subscription tab. See screenshot attached.