|
Description
Michael Cabus
2017-03-30 18:10:09 UTC
Created attachment 63661 [details] [review] Bug 18354 Adding item type attribute to cover image div this adds item type so we can do things with javascript To Test 1.) Do a search on OPAC 2.) Inspect element to confirm item type is not present 3.) Apply patch 4.) Do a search on OPAC to confirm item Created attachment 63705 [details] [review] [SIGNED-OFF] Bug 18354 Adding item type attribute to cover image div This adds item type so we can do things with javascript. To Test: 1.) Do a search on OPAC 2.) Inspect element to confirm item type is not present 3.) Apply patch 4.) Do a search on OPAC to confirm item type is present as a class Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 66470 [details] [review] Bug 18354 Adding item type attribute to cover image div This adds item type so we can do things with javascript. To Test: 1.) Do a search on OPAC 2.) Inspect element to confirm item type is not present 3.) Apply patch 4.) Do a search on OPAC to confirm item type is present as a class Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 66471 [details] [review] Bug 18354: [QA Follow-up] Add a prefix for the itemtype class Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Michael, This has been waiting much too long in our QA queue. But pasting itemtype as-is into the class might have side-effects we cannot oversee. That string can be just about everything. Wouldn't it be better to prefix it with something as itemtype_ ? In view of time elapsed, I add that as a follow-up and move it to PQA. Feel free to respond if you have a better idea. Marcel Hi That would be a great idea and still retain the intended purpose. Thanks so much Michael Cabus Pushed to master for 17.11, thanks to everybody involved! If SEARCH_RESULT.itemtype can be undefined, is class "itemtype_" valid ? |